Details
Details
- Reviewers
arsenm foad - Commits
- rGc46d99e4ba16: [AMDGPU] Refine -O0 and -O1 passes.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp | ||
---|---|---|
1102 | The real fixme is we should not be relying on attribute propagation for correctness |
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp | ||
---|---|---|
1102 | I have just moved lost comment. Do you want to change it? |
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp | ||
---|---|---|
1102 | I guess the problem exists beyond here and the comment is out of place. I guess just drop the comment? |
Comment Actions
Looks fine to me.
Adding @piotr because this should improve compile times.
Adding @sebastian-ne because of the discussion about propagating attributes being required for correctness in the presence of calls.
The real fixme is we should not be relying on attribute propagation for correctness