This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Refine -O0 and -O1 passes.
ClosedPublic

Authored by rampitec on Jul 7 2021, 12:05 PM.

Diff Detail

Event Timeline

rampitec created this revision.Jul 7 2021, 12:05 PM
rampitec requested review of this revision.Jul 7 2021, 12:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2021, 12:05 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.Jul 7 2021, 12:23 PM
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
1102

The real fixme is we should not be relying on attribute propagation for correctness

rampitec added inline comments.Jul 7 2021, 12:25 PM
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
1102

I have just moved lost comment. Do you want to change it?

arsenm added inline comments.Jul 7 2021, 12:26 PM
llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
1102

I guess the problem exists beyond here and the comment is out of place. I guess just drop the comment?

rampitec updated this revision to Diff 357049.Jul 7 2021, 12:32 PM
rampitec marked 2 inline comments as done.

Dropped comment.

rampitec updated this revision to Diff 358667.Jul 14 2021, 11:03 AM
rampitec added a reviewer: foad.

Rebased.

foad accepted this revision.Jul 15 2021, 2:30 AM
foad added subscribers: sebastian-ne, piotr.

Looks fine to me.

Adding @piotr because this should improve compile times.

Adding @sebastian-ne because of the discussion about propagating attributes being required for correctness in the presence of calls.

This revision is now accepted and ready to land.Jul 15 2021, 2:30 AM
This revision was landed with ongoing or failed builds.Jul 15 2021, 9:52 AM
This revision was automatically updated to reflect the committed changes.