Tiling can be enabled with linalg-tile-pad-tensor-ops. Only scf::ForOp can be generated at the moment.
Depends On D105602
Paths
| Differential D105460
[mlir][linalg] Tile PadTensorOp ClosedPublic Authored by springerm on Jul 5 2021, 11:46 PM.
Details
Summary Tiling can be enabled with linalg-tile-pad-tensor-ops. Only scf::ForOp can be generated at the moment. Depends On D105602
Diff Detail
Unit TestsFailed Event TimelineHerald added subscribers: dcaballe, cota, mravishankar and 17 others. · View Herald TranscriptJul 5 2021, 11:46 PM nicolasvasilache added inline comments.
This revision now requires changes to proceed.Jul 7 2021, 12:44 PM springerm added a parent revision: D105602: [mlir][NFC] Move asOpFoldResult helper functions to StaticValueUtils. springerm marked an inline comment as done. Comment Actionsaddress comments
This revision is now accepted and ready to land.Jul 14 2021, 12:09 AM This revision was landed with ongoing or failed builds.Jul 14 2021, 6:42 PM Closed by commit rG4064b6a36348: [mlir][linalg] Tile PadTensorOp (authored by springerm). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 356683 mlir/include/mlir/Dialect/Linalg/Passes.h
mlir/include/mlir/Dialect/Linalg/Passes.td
mlir/include/mlir/Dialect/Linalg/Utils/Utils.h
mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
mlir/test/Dialect/Linalg/tile-pad-tensor-op.mlir
|
Can this be folded into the existing tiling pass ?
These are pure mechanics and don't have any policy / heuristics logic anyway.
They are not meant to drive anything other than tests.
Moving them to purely test patterns would also be appropriate.