This is an archive of the discontinued LLVM Phabricator instance.

Differential D105124

[ARM][NFC] Remove an unused method
ClosedPublic

Authored by ikudrin on Jun 29 2021, 8:05 AM.

Details

Reviewers
simon_tatham
samparker
ostannard
Commits
rG17bcae890694: [ARM][NFC] Remove an unused method
Summary

ARMInstPrinter::printMveAddrModeQOperand() was added in D62680, but was never used. It looks like printT2AddrModeImm8Operand<false>() is used instead.

Diff Detail

Event Timeline

ikudrin created this revision.Jun 29 2021, 8:05 AM
Herald added subscribers: danielkiss, dmgreen, hiraditya, kristof.beyls. · View Herald TranscriptJun 29 2021, 8:05 AM
ikudrin requested review of this revision.Jun 29 2021, 8:05 AM
Harbormaster completed remote builds in B111537: Diff 355247.Jun 29 2021, 8:55 AM
simon_tatham accepted this revision.Jun 29 2021, 9:16 AM

Good catch!

This revision is now accepted and ready to land.Jun 29 2021, 9:16 AM
Closed by commit rG17bcae890694: [ARM][NFC] Remove an unused method (authored by ikudrin). · Explain WhyJun 30 2021, 1:56 AM
This revision was automatically updated to reflect the committed changes.
ikudrin added a commit: rG17bcae890694: [ARM][NFC] Remove an unused method.

Revision Contents

PathSize
llvm/
lib/
Target/
ARM/
MCTargetDesc/
2 lines
16 lines

Diff 355247

llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h

Show First 20 Lines • Show All 268 Lines • ▼ Show 20 Linespublic:
void printVPTPredicateOperand(const MCInst *MI, unsigned OpNum, void printVPTPredicateOperand(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, const MCSubtargetInfo &STI,
raw_ostream &O); raw_ostream &O);
void printVPTMask(const MCInst *MI, unsigned OpNum, void printVPTMask(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, raw_ostream &O); const MCSubtargetInfo &STI, raw_ostream &O);
template<int shift> template<int shift>
void printMveAddrModeRQOperand(const MCInst *MI, unsigned OpNum, void printMveAddrModeRQOperand(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, raw_ostream &O); const MCSubtargetInfo &STI, raw_ostream &O);
void printMveAddrModeQOperand(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, raw_ostream &O);
void printMveSaturateOp(const MCInst *MI, unsigned OpNum, void printMveSaturateOp(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, raw_ostream &O); const MCSubtargetInfo &STI, raw_ostream &O);
private: private:
unsigned DefaultAltIdx = ARM::NoRegAltName; unsigned DefaultAltIdx = ARM::NoRegAltName;
}; };
} // end namespace llvm } // end namespace llvm
#endif // LLVM_LIB_TARGET_ARM_MCTARGETDESC_ARMINSTPRINTER_H #endif // LLVM_LIB_TARGET_ARM_MCTARGETDESC_ARMINSTPRINTER_H

llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp

Show First 20 Lines • Show All 616 Lines • ▼ Show 20 Linesvoid ARMInstPrinter::printMveAddrModeRQOperand(const MCInst *MI, unsigned OpNum,
printRegName(O, MO2.getReg()); printRegName(O, MO2.getReg());
if (shift > 0) if (shift > 0)
printRegImmShift(O, ARM_AM::uxtw, shift, UseMarkup); printRegImmShift(O, ARM_AM::uxtw, shift, UseMarkup);
O << "]" << markup(">"); O << "]" << markup(">");
} }
void ARMInstPrinter::printMveAddrModeQOperand(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI,
raw_ostream &O) {
const MCOperand &MO1 = MI->getOperand(OpNum);
const MCOperand &MO2 = MI->getOperand(OpNum + 1);
O << markup("<mem:") << "[";
printRegName(O, MO1.getReg());
int64_t Imm = MO2.getImm();
if (Imm != 0)
O << ", " << markup("<imm:") << '#' << Imm << markup(">");
O << "]" << markup(">");
}
void ARMInstPrinter::printLdStmModeOperand(const MCInst *MI, unsigned OpNum, void ARMInstPrinter::printLdStmModeOperand(const MCInst *MI, unsigned OpNum,
const MCSubtargetInfo &STI, const MCSubtargetInfo &STI,
raw_ostream &O) { raw_ostream &O) {
ARM_AM::AMSubMode Mode = ARM_AM::AMSubMode Mode =
ARM_AM::getAM4SubMode(MI->getOperand(OpNum).getImm()); ARM_AM::getAM4SubMode(MI->getOperand(OpNum).getImm());
O << ARM_AM::getAMSubModeStr(Mode); O << ARM_AM::getAMSubModeStr(Mode);
} }
▲ Show 20 Lines • Show All 1,030 Lines • Show Last 20 Lines