This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Run the OpenMPOpt module pass at O1
ClosedPublic

Authored by jhuber6 on Jun 28 2021, 12:58 PM.

Details

Summary

Now that the OpenMPOpt module pass include important optimizations for removing
globalization from offloading regions it should be run at a lower optimization
level.

Diff Detail

Unit TestsFailed

Event Timeline

jhuber6 created this revision.Jun 28 2021, 12:58 PM
jhuber6 requested review of this revision.Jun 28 2021, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2021, 12:58 PM
jdoerfert accepted this revision.Jun 28 2021, 1:03 PM

LGTM. Since this affects only modules compiled with -fopenmp it should be OK to run OpenMPOpt at O1.

This revision is now accepted and ready to land.Jun 28 2021, 1:03 PM

LGTM. Since this affects only modules compiled with -fopenmp it should be OK to run OpenMPOpt at O1.

Should I put it on the CGSCC pass as well then?

jhuber6 updated this revision to Diff 355010.Jun 28 2021, 1:11 PM

Fixing tests

This revision was landed with ongoing or failed builds.Jun 28 2021, 3:48 PM
This revision was automatically updated to reflect the committed changes.