Page MenuHomePhabricator

[llvm][ARM] Treat xscale arch as an alias of armv5te
ClosedPublic

Authored by DavidSpickett on Jun 23 2021, 4:17 AM.

Details

Summary

Previously xscale was known to everything apart
from the ELF streamer so we would crash as soon
as you tried to output an object file.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jun 23 2021, 4:17 AM
DavidSpickett requested review of this revision.Jun 23 2021, 4:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2021, 4:17 AM

For https://github.com/ClangBuiltLinux/linux/issues/1276

I'm not sure if xscale should enable iwmmxt, the best "docs" seem to be the wiki (https://en.wikipedia.org/wiki/XScale). Which says there were some xscale with this feature (v1 or v2 not sure).

There are special arch names for IWMMXT and IWMMXT2 so if the user really wants them they can do so by changing their .arch directive.

I'm not sure if xscale should enable iwmmxt, the best "docs" seem to be the wiki (https://en.wikipedia.org/wiki/XScale). Which says there were some xscale with this feature (v1 or v2 not sure).

Confirmed that GAS sets the same attributes for xscale so I think what's here is correct.

Rebase on main.

This revision is now accepted and ready to land.Jun 25 2021, 3:18 PM
This revision was landed with ongoing or failed builds.Jun 28 2021, 8:20 AM
This revision was automatically updated to reflect the committed changes.