This is an archive of the discontinued LLVM Phabricator instance.

Differential D104688

[NFC][PDL] Fix documentation typo, redundant test
ClosedPublic

Authored by vinayaka-polymage on Jun 21 2021, 10:49 PM.

Details

Reviewers
pr4tgpt
bondhugula
rriddle
Commits
rG0e55112242f6: [NFC][PDL] Fix documentation typo, redundant test
Summary

Correct a documentation typo, and delete a duplicate test in
pdl-to-pdl-interp-rewriter.mlir.

Diff Detail

Unit TestsFailed

TimeTest
1,190 msx64 windows > lit.lit::test-output.py

Event Timeline

vinayaka-polymage created this revision.Jun 21 2021, 10:49 PM
Herald added subscribers: ormris, dcaballe, cota and 19 others. · View Herald TranscriptJun 21 2021, 10:49 PM
vinayaka-polymage requested review of this revision.Jun 21 2021, 10:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2021, 10:49 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
bondhugula accepted this revision.Jun 21 2021, 11:01 PM
This revision is now accepted and ready to land.Jun 21 2021, 11:01 PM
bondhugula added a reviewer: rriddle.Jun 21 2021, 11:01 PM
pr4tgpt accepted this revision.Jun 21 2021, 11:03 PM

LGTM!

Harbormaster completed remote builds in B110341: Diff 353554.Jun 21 2021, 11:23 PM
rriddle accepted this revision.Jun 21 2021, 11:24 PM

Nice catch!

This revision was landed with ongoing or failed builds.Jun 22 2021, 11:57 PM
Closed by commit rG0e55112242f6: [NFC][PDL] Fix documentation typo, redundant test (authored by vinayaka-polymage, committed by bondhugula). · Explain Why
This revision was automatically updated to reflect the committed changes.
bondhugula added a commit: rG0e55112242f6: [NFC][PDL] Fix documentation typo, redundant test.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
PDL/
IR/
4 lines
test/
Conversion/
PDLToPDLInterp/
22 lines

Diff 353554

mlir/include/mlir/Dialect/PDL/IR/PDLDialect.td

Show All 29 Lines string description = [{
correctness, targeted by frontends, and optimized. correctness, targeted by frontends, and optimized.
PDL abstracts over various different aspects of patterns and core MLIR data PDL abstracts over various different aspects of patterns and core MLIR data
structures. Patterns are specified via a `pdl.pattern` operation. These structures. Patterns are specified via a `pdl.pattern` operation. These
operations contain a region body for the "matcher" code, and terminate with operations contain a region body for the "matcher" code, and terminate with
a `pdl.rewrite` that either dispatches to an external rewriter or contains a `pdl.rewrite` that either dispatches to an external rewriter or contains
a region for the rewrite specified via `pdl`. The types of values in `pdl` a region for the rewrite specified via `pdl`. The types of values in `pdl`
are handle types to MLIR C++ types, with `!pdl.attribute`, `!pdl.operation`, are handle types to MLIR C++ types, with `!pdl.attribute`, `!pdl.operation`,
and `!pdl.type` directly mapping to `mlir::Attribute`, `mlir::Operation*`, `!pdl.value`, and `!pdl.type` directly mapping to `mlir::Attribute`,
and `mlir::Value` respectively. `mlir::Operation*`, `mlir::Value`, and `mlir::Type` respectively.
An example pattern is shown below: An example pattern is shown below:
```mlir ```mlir
// pdl.pattern contains metadata similarly to a `RewritePattern`. // pdl.pattern contains metadata similarly to a `RewritePattern`.
pdl.pattern : benefit(1) { pdl.pattern : benefit(1) {
// External input operand values are specified via `pdl.operand` operations. // External input operand values are specified via `pdl.operand` operations.
// Result types are constrainted via `pdl.type` operations. // Result types are constrainted via `pdl.type` operations.
Show All 25 Lines

mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-rewriter.mlir

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines pdl.rewrite %root {
%newOp1 = pdl.operation "foo.op2"(%result : !pdl.value) %newOp1 = pdl.operation "foo.op2"(%result : !pdl.value)
pdl.erase %root pdl.erase %root
} }
} }
} }
// ----- // -----
// CHECK-LABEL: module @operation_operands
module @operation_operands {
// CHECK: module @rewriters
// CHECK: func @pdl_generated_rewriter(%[[OPERAND:.*]]: !pdl.value, %[[ROOT:.*]]: !pdl.operation)
// CHECK: %[[NEWOP:.*]] = pdl_interp.create_operation "foo.op"(%[[OPERAND]] : !pdl.value)
// CHECK: %[[OPERAND1:.*]] = pdl_interp.get_result 0 of %[[NEWOP]]
// CHECK: pdl_interp.create_operation "foo.op2"(%[[OPERAND1]] : !pdl.value)
pdl.pattern : benefit(1) {
%operand = pdl.operand
%root = pdl.operation "foo.op"(%operand : !pdl.value)
pdl.rewrite %root {
%type = pdl.type : i32
%newOp = pdl.operation "foo.op"(%operand : !pdl.value) -> (%type : !pdl.type)
%result = pdl.result 0 of %newOp
%newOp1 = pdl.operation "foo.op2"(%result : !pdl.value)
pdl.erase %root
}
}
}
// -----
// CHECK-LABEL: module @operation_infer_types_from_replaceop // CHECK-LABEL: module @operation_infer_types_from_replaceop
module @operation_infer_types_from_replaceop { module @operation_infer_types_from_replaceop {
// CHECK: module @rewriters // CHECK: module @rewriters
// CHECK: func @pdl_generated_rewriter(%[[ROOT:.*]]: !pdl.operation // CHECK: func @pdl_generated_rewriter(%[[ROOT:.*]]: !pdl.operation
// CHECK: %[[RESULTS:.*]] = pdl_interp.get_results of %[[ROOT]] // CHECK: %[[RESULTS:.*]] = pdl_interp.get_results of %[[ROOT]]
// CHECK: %[[RESULT_TYPES:.*]] = pdl_interp.get_value_type of %[[RESULTS]] // CHECK: %[[RESULT_TYPES:.*]] = pdl_interp.get_value_type of %[[RESULTS]]
// CHECK: pdl_interp.create_operation "foo.op" -> (%[[RESULT_TYPES]] : !pdl.range<type>) // CHECK: pdl_interp.create_operation "foo.op" -> (%[[RESULT_TYPES]] : !pdl.range<type>)
pdl.pattern : benefit(1) { pdl.pattern : benefit(1) {
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines