This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] integration test for "simply dynamic" sparse output tensors
ClosedPublic

Authored by aartbik on Jun 18 2021, 6:13 PM.

Diff Detail

Event Timeline

aartbik created this revision.Jun 18 2021, 6:13 PM
aartbik requested review of this revision.Jun 18 2021, 6:13 PM
gussmith23 accepted this revision.Jun 22 2021, 11:05 AM
gussmith23 added inline comments.
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_out_simple.mlir
21

Did you mean to call this matvec?

41

The inplacable = true here is required, correct?

This revision is now accepted and ready to land.Jun 22 2021, 11:05 AM
aartbik marked 2 inline comments as done.Jun 22 2021, 1:39 PM
aartbik added inline comments.
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_out_simple.mlir
21

No, not at all. Very good catch!

41

Yes, even though the sparse storage scheme is really bufferized into a rt support library data structure, the inplace tells us same-in-out behavior is okay.

aartbik updated this revision to Diff 353778.Jun 22 2021, 1:57 PM
aartbik marked 2 inline comments as done.

fixed naming

This revision was landed with ongoing or failed builds.Jun 22 2021, 2:28 PM
This revision was automatically updated to reflect the committed changes.