Page MenuHomePhabricator

[UpdateCCTestChecks] Fix --replace-value-regex across RUN lines
ClosedPublic

Authored by jdenny on Jun 18 2021, 12:48 PM.

Details

Summary

Without this patch, llvm/utils/update_cc_test_checks.py fails to
perform --replace-value-regex replacements when two RUN lines
produce the same output and use the same single FileCheck prefix. The
problem is that replacements in a RUN line's output are not performed
until after comparing against previous RUN lines' output, where
replacements have already been performed. This patch fixes that.

Diff Detail

Event Timeline

jdenny requested review of this revision.Jun 18 2021, 12:48 PM
jdenny created this revision.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 18 2021, 12:48 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
This revision is now accepted and ready to land.Jun 21 2021, 12:02 PM
This revision was landed with ongoing or failed builds.Jun 21 2021, 2:08 PM
This revision was automatically updated to reflect the committed changes.