This is an archive of the discontinued LLVM Phabricator instance.

Differential D104517

[mlir][Vector] Add integration tests for ArmSVE
ClosedPublic

Authored by jsetoain on Jun 18 2021, 3:33 AM.

Details

Reviewers
aartbik
nicolasvasilache
Commits
rGccb54d5b4203: [mlir][Vector] Add integration tests for ArmSVE
Summary

In order to run these integration tests, it is required access to an
SVE-enabled CPU or and emulator with SVE support. In case of using
an emulator, aarch64 versions of lli and the MLIR C Runner Utils Library
are also required.

Diff Detail

Event Timeline

jsetoain created this revision.Jun 18 2021, 3:33 AM
Herald added subscribers: dcaballe, cota, teijeong and 18 others. · View Herald TranscriptJun 18 2021, 3:33 AM
Matt added a subscriber: Matt.Jun 18 2021, 11:41 AM
Harbormaster completed remote builds in B109896: Diff 352963.Jun 18 2021, 7:48 PM
jsetoain updated this revision to Diff 357469.Jul 9 2021, 3:42 AM

Adapt tests to https://reviews.llvm.org/D105625

Harbormaster completed remote builds in B113169: Diff 357469.Jul 9 2021, 4:19 AM
jsetoain updated this revision to Diff 402568.Jan 24 2022, 9:30 AM

Updated to latest changes in main

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 2 others. · View Herald TranscriptJan 24 2022, 9:30 AM
Harbormaster completed remote builds in B145258: Diff 402568.Jan 26 2022, 10:24 AM
jsetoain updated this revision to Diff 404066.Jan 28 2022, 9:53 AM

Add a slightly more interesting test

jsetoain published this revision for review.Jan 28 2022, 9:55 AM
jsetoain added a parent revision: D118248: [mlir][Vector] Enable create_mask for scalable vectors.
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 9:56 AM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
Harbormaster completed remote builds in B146319: Diff 404066.Jan 28 2022, 10:34 AM
nicolasvasilache accepted this revision.Feb 8 2022, 4:46 AM

Nice!

This revision is now accepted and ready to land.Feb 8 2022, 4:46 AM
jsetoain updated this revision to Diff 407199.Feb 9 2022, 10:09 AM

Rebase on main

Harbormaster completed remote builds in B148511: Diff 407199.Feb 9 2022, 10:55 AM
jsetoain added a child revision: D121304: [mlir][sparse][ArmSVE] Add sparse integration tests for ArmSVE.Mar 9 2022, 9:18 AM
jsetoain updated this revision to Diff 418201.Mar 25 2022, 6:13 AM

Rebase on main

Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 6:13 AM
This revision was landed with ongoing or failed builds.Mar 25 2022, 6:21 AM
Closed by commit rGccb54d5b4203: [mlir][Vector] Add integration tests for ArmSVE (authored by jsetoain). · Explain Why
This revision was automatically updated to reflect the committed changes.
jsetoain added a commit: rGccb54d5b4203: [mlir][Vector] Add integration tests for ArmSVE.
Harbormaster completed remote builds in B156268: Diff 418201.Mar 25 2022, 6:38 AM
jsetoain removed a child revision: D121304: [mlir][sparse][ArmSVE] Add sparse integration tests for ArmSVE.Apr 26 2022, 7:12 AM

Revision Contents

PathSize
mlir/
test/
9 lines
Integration/
Dialect/
Vector/
CPU/
ArmSVE/
29 lines
154 lines
5 lines

Diff 402568

mlir/test/CMakeLists.txt

Show All 17 Lines
# Passed to lit.site.cfg.py.in to set up the path where to find the libraries # Passed to lit.site.cfg.py.in to set up the path where to find the libraries
# for the mlir spirv / vulkan runner tests. # for the mlir spirv / vulkan runner tests.
set(MLIR_SPIRV_WRAPPER_LIBRARY_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) set(MLIR_SPIRV_WRAPPER_LIBRARY_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
set(MLIR_VULKAN_WRAPPER_LIBRARY_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) set(MLIR_VULKAN_WRAPPER_LIBRARY_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
if (MLIR_INCLUDE_INTEGRATION_TESTS) if (MLIR_INCLUDE_INTEGRATION_TESTS)
set(INTEL_SDE_EXECUTABLE "" CACHE STRING set(INTEL_SDE_EXECUTABLE "" CACHE STRING
"If set, arch-specific integration tests are run with Intel SDE.") "If set, arch-specific integration tests are run with Intel SDE.")
set(ARM_EMULATOR_EXECUTABLE "" CACHE STRING
"If set, arch-specific Arm integration tests are run with an emulator.")
set(ARM_EMULATOR_OPTIONS "" CACHE STRING
"If arch-specific Arm integration tests run emulated, pass these as parameters to the emulator.")
set(ARM_EMULATOR_LLI_EXECUTABLE "" CACHE STRING
"If arch-specific Arm integration tests run emulated, use this Arm native lli.")
set(ARM_EMULATOR_UTILS_LIB_DIR "" CACHE STRING
"If arch-specific Arm integration tests run emulated, find Arm native utility libraries in this directory.")
option(MLIR_RUN_AMX_TESTS "Run AMX tests.") option(MLIR_RUN_AMX_TESTS "Run AMX tests.")
option(MLIR_RUN_X86VECTOR_TESTS "Run X86Vector tests.") option(MLIR_RUN_X86VECTOR_TESTS "Run X86Vector tests.")
option(MLIR_RUN_CUDA_TENSOR_CORE_TESTS "Run CUDA Tensor core WMMA tests.") option(MLIR_RUN_CUDA_TENSOR_CORE_TESTS "Run CUDA Tensor core WMMA tests.")
option(MLIR_RUN_ARM_SVE_TESTS "Run Arm SVE tests.")
# Passed to lit.site.cfg.py.in to set up the path where to find the libraries. # Passed to lit.site.cfg.py.in to set up the path where to find the libraries.
set(MLIR_INTEGRATION_TEST_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}) set(MLIR_INTEGRATION_TEST_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
# The native target may not be enabled when cross compiling, raise an error. # The native target may not be enabled when cross compiling, raise an error.
if(NOT TARGET ${LLVM_NATIVE_ARCH}) if(NOT TARGET ${LLVM_NATIVE_ARCH})
message(FATAL_ERROR "MLIR_INCLUDE_INTEGRATION_TESTS requires a native target") message(FATAL_ERROR "MLIR_INCLUDE_INTEGRATION_TESTS requires a native target")
endif() endif()
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines

mlir/test/Integration/Dialect/Vector/CPU/ArmSVE/lit.local.cfg

  • This file was added.
import sys
# ArmSVE tests must be enabled via build flag.
if config.mlir_run_arm_sve_tests != 'ON':
config.unsupported = True
# No JIT on win32.
if sys.platform == 'win32':
config.unsupported = True
lli_cmd = 'lli'
if config.arm_emulator_lli_executable:
lli_cmd = config.arm_emulator_lli_executable
if config.arm_emulator_utils_lib_dir:
config.substitutions.append(('%mlir_native_utils_lib_dir', config.arm_emulator_utils_lib_dir))
else:
config.substitutions.append(('%mlir_native_utils_lib_dir', config.mlir_integration_test_dir))
config.substitutions.append(('%mlir_native_utils_lib_dir', config.mlir_integration_test_dir))
if config.arm_emulator_executable:
# Run test in emulator (qemu or armie)
emulation_cmd = config.arm_emulator_executable
if config.arm_emulator_options:
emulation_cmd = emulation_cmd + ' ' + config.arm_emulator_options
emulation_cmd = emulation_cmd + ' ' + lli_cmd
config.substitutions.append(('%lli', emulation_cmd))
else:
config.substitutions.append(('%lli', lli_cmd))

mlir/test/Integration/Dialect/Vector/CPU/ArmSVE/test-sve.mlir

  • This file was added.
// RUN: mlir-opt %s -convert-vector-to-scf -lower-affine -convert-scf-to-std -convert-vector-to-llvm="enable-arm-sve" -convert-memref-to-llvm -convert-std-to-llvm -reconcile-unrealized-casts | \
// RUN: mlir-translate -mlir-to-llvmir | \
// RUN: %lli --entry-function=entry --march=aarch64 --mattr="+sve" --dlopen=%mlir_native_utils_lib_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s
// Note: To run this test, your CPU must support SVE
// SVE-based memcopy
func @kernel_copy(%src : memref<?xi64>, %dst : memref<?xi64>, %size : index) {
%c0 = arith.constant 0 : index
%c2 = arith.constant 2 : index
%vs = vector.vscale
%step = arith.muli %c2, %vs : index
scf.for %i0 = %c0 to %size step %step {
%0 = vector.load %src[%i0] : memref<?xi64>, vector<[2]xi64>
vector.store %0, %dst[%i0] : memref<?xi64>, vector<[2]xi64>
}
return
}
// SVE-based multiply and add
func @kernel_muladd(%a : memref<?xi64>,
%b : memref<?xi64>,
%c : memref<?xi64>,
%size : index) {
%c0 = arith.constant 0 : index
%c2 = arith.constant 2 : index
%vs = vector.vscale
%step = arith.muli %c2, %vs : index
scf.for %i0 = %c0 to %size step %step {
%0 = vector.load %a[%i0] : memref<?xi64>, vector<[2]xi64>
%1 = vector.load %b[%i0] : memref<?xi64>, vector<[2]xi64>
%2 = vector.load %c[%i0] : memref<?xi64>, vector<[2]xi64>
%3 = arith.muli %0, %1 : vector<[2]xi64>
%4 = arith.addi %3, %2 : vector<[2]xi64>
vector.store %4, %c[%i0] : memref<?xi64>, vector<[2]xi64>
}
return
}
// SVE-based absolute difference
func @kernel_absdiff(%a : memref<?xi64>,
%b : memref<?xi64>,
%c : memref<?xi64>,
%size : index) {
%c0 = arith.constant 0 : index
%c2 = arith.constant 2 : index
%vs = vector.vscale
%step = arith.muli %c2, %vs : index
scf.for %i0 = %c0 to %size step %step {
%0 = vector.load %a[%i0] : memref<?xi64>, vector<[2]xi64>
%1 = vector.load %b[%i0] : memref<?xi64>, vector<[2]xi64>
%agb = arith.cmpi sge, %0, %1 : vector<[2]xi64>
%bga = arith.cmpi slt, %0, %1 : vector<[2]xi64>
%10 = arm_sve.masked.subi %agb, %0, %1 : vector<[2]xi1>,
vector<[2]xi64>
%01 = arm_sve.masked.subi %bga, %1, %0 : vector<[2]xi1>,
vector<[2]xi64>
vector.maskedstore %c[%i0], %agb, %10 : memref<?xi64>,
vector<[2]xi1>,
vector<[2]xi64>
vector.maskedstore %c[%i0], %bga, %01 : memref<?xi64>,
vector<[2]xi1>,
vector<[2]xi64>
}
return
}
func @entry() -> i32 {
%i0 = arith.constant 0: i64
%i1 = arith.constant 1: i64
%r0 = arith.constant 0: i32
%c0 = arith.constant 0: index
%c1 = arith.constant 1: index
%c2 = arith.constant 2: index
%c4 = arith.constant 4: index
%c8 = arith.constant 8: index
%c32 = arith.constant 32: index
// Set up memory.
%a = memref.alloc() : memref<32xi64>
%a_copy = memref.alloc() : memref<32xi64>
%b = memref.alloc() : memref<32xi64>
%c = memref.alloc() : memref<32xi64>
%d = memref.alloc() : memref<32xi64>
%a_data = arith.constant dense<[1 , 2, 3 , 4 , 5, 6, 7, 8,
9, 10, 11, 12, 13, 14, 15, 16,
17, 18, 19, 20, 21, 22, 23, 24,
25, 26, 27, 28, 29, 30, 31, 32]> : vector<32xi64>
vector.transfer_write %a_data, %a[%c0] : vector<32xi64>, memref<32xi64>
%b_data = arith.constant dense<[33, 34, 35, 36, 37, 38, 39, 40,
41, 42, 43, 44, 45, 46, 47, 48,
49, 50, 51, 52, 53, 54, 55, 56,
57, 58, 59, 60, 61, 62, 63, 64]> : vector<32xi64>
vector.transfer_write %b_data, %b[%c0] : vector<32xi64>, memref<32xi64>
%d_data = arith.constant dense<[-9, 76, -7, 78, -5, 80, -3, 82,
-1, 84, 1, 86, 3, 88, 5, 90,
7, 92, 9, 94, 11, 96, 13, 98,
15, 100, 17, 102, 19, 104, 21, 106]> : vector<32xi64>
vector.transfer_write %d_data, %d[%c0] : vector<32xi64>, memref<32xi64>
%zero_data = vector.broadcast %i0 : i64 to vector<32xi64>
vector.transfer_write %zero_data, %a_copy[%c0] : vector<32xi64>, memref<32xi64>
%one_data = vector.broadcast %i1 : i64 to vector<32xi64>
vector.transfer_write %one_data, %c[%c0] : vector<32xi64>, memref<32xi64>
// Call kernel.
%0 = memref.cast %a : memref<32xi64> to memref<?xi64>
%1 = memref.cast %a_copy : memref<32xi64> to memref<?xi64>
call @kernel_copy(%0, %1, %c32) : (memref<?xi64>, memref<?xi64>, index) -> ()
// Print and verify.
//
// CHECK: ( 1, 2, 3, 4 )
// CHECK-NEXT: ( 5, 6, 7, 8 )
scf.for %i = %c0 to %c32 step %c4 {
%cv = vector.transfer_read %a_copy[%i], %i0: memref<32xi64>, vector<4xi64>
vector.print %cv : vector<4xi64>
}
%2 = memref.cast %a : memref<32xi64> to memref<?xi64>
%3 = memref.cast %b : memref<32xi64> to memref<?xi64>
%4 = memref.cast %c : memref<32xi64> to memref<?xi64>
call @kernel_muladd(%2, %3, %4, %c32) : (memref<?xi64>, memref<?xi64>, memref<?xi64>, index) -> ()
// CHECK: ( 34, 69, 106, 145 )
// CHECK-NEXT: ( 186, 229, 274, 321 )
scf.for %i = %c0 to %c32 step %c4 {
%macv = vector.transfer_read %c[%i], %i0: memref<32xi64>, vector<4xi64>
vector.print %macv : vector<4xi64>
}
%5 = memref.cast %b : memref<32xi64> to memref<?xi64>
%6 = memref.cast %d : memref<32xi64> to memref<?xi64>
%7 = memref.cast %c : memref<32xi64> to memref<?xi64>
call @kernel_absdiff(%5, %6, %7, %c32) : (memref<?xi64>, memref<?xi64>, memref<?xi64>, index) -> ()
// CHECK: ( 42, 42, 42, 42 )
// CHECK-NEXT: ( 42, 42, 42, 42 )
scf.for %i = %c0 to %c32 step %c4 {
%abdv = vector.transfer_read %c[%i], %i0: memref<32xi64>, vector<4xi64>
vector.print %abdv : vector<4xi64>
}
// Release resources.
memref.dealloc %a : memref<32xi64>
memref.dealloc %a_copy : memref<32xi64>
memref.dealloc %b : memref<32xi64>
memref.dealloc %c : memref<32xi64>
memref.dealloc %d : memref<32xi64>
return %r0 : i32
}

mlir/test/lit.site.cfg.py.in

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
config.enable_vulkan_runner = @MLIR_ENABLE_VULKAN_RUNNER@ config.enable_vulkan_runner = @MLIR_ENABLE_VULKAN_RUNNER@
config.enable_bindings_python = @MLIR_ENABLE_BINDINGS_PYTHON@ config.enable_bindings_python = @MLIR_ENABLE_BINDINGS_PYTHON@
config.mlir_integration_test_dir = "@MLIR_INTEGRATION_TEST_DIR@" config.mlir_integration_test_dir = "@MLIR_INTEGRATION_TEST_DIR@"
config.intel_sde_executable = "@INTEL_SDE_EXECUTABLE@" config.intel_sde_executable = "@INTEL_SDE_EXECUTABLE@"
config.mlir_run_amx_tests = @MLIR_RUN_AMX_TESTS@ config.mlir_run_amx_tests = @MLIR_RUN_AMX_TESTS@
config.mlir_run_x86vector_tests = @MLIR_RUN_X86VECTOR_TESTS@ config.mlir_run_x86vector_tests = @MLIR_RUN_X86VECTOR_TESTS@
config.mlir_run_cuda_tensor_core_tests = @MLIR_RUN_CUDA_TENSOR_CORE_TESTS@ config.mlir_run_cuda_tensor_core_tests = @MLIR_RUN_CUDA_TENSOR_CORE_TESTS@
config.mlir_include_integration_tests = @MLIR_INCLUDE_INTEGRATION_TESTS@ config.mlir_include_integration_tests = @MLIR_INCLUDE_INTEGRATION_TESTS@
config.arm_emulator_executable = "@ARM_EMULATOR_EXECUTABLE@"
config.arm_emulator_options = "@ARM_EMULATOR_OPTIONS@"
config.arm_emulator_lli_executable = "@ARM_EMULATOR_LLI_EXECUTABLE@"
config.arm_emulator_utils_lib_dir = "@ARM_EMULATOR_UTILS_LIB_DIR@"
config.mlir_run_arm_sve_tests = "@MLIR_RUN_ARM_SVE_TESTS@"
# Support substitution of the tools_dir with user parameters. This is # Support substitution of the tools_dir with user parameters. This is
# used when we can't determine the tool dir at configuration time. # used when we can't determine the tool dir at configuration time.
try: try:
config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params config.llvm_lib_dir = config.llvm_lib_dir % lit_config.params
config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
except KeyError: except KeyError:
Show All 9 Lines