Page MenuHomePhabricator

[mlir][linalg] Adapt the FillOp builder signature.
ClosedPublic

Authored by gysit on Jun 16 2021, 12:09 AM.

Details

Summary

Change the build operand order from output, value to value, output. The patch makes the argument order consistent with the pretty printed order updated by https://reviews.llvm.org/D104356.

Diff Detail

Event Timeline

gysit created this revision.Jun 16 2021, 12:09 AM
gysit requested review of this revision.Jun 16 2021, 12:09 AM

With these uniformizations, do we need the custom printer and parser anymore (modulo some more minor spelling uniformizations re ins/outs) ?

This revision is now accepted and ready to land.Jun 21 2021, 12:17 AM

With these uniformizations, do we need the custom printer and parser anymore (modulo some more minor spelling uniformizations re ins/outs) ?

I would probably do that when switching to an OpDSL version?

This revision was landed with ongoing or failed builds.Jun 23 2021, 1:07 AM
This revision was automatically updated to reflect the committed changes.