Page MenuHomePhabricator

[ConstantFolding] Enable folding of min/max/copysign for all floats
ClosedPublic

Authored by sepavloff on Jun 9 2021, 5:20 AM.

Details

Summary

Previously such folding was enabled for half, float and double values
only. With this change it is allowed for other floating point values
also.

Diff Detail

Event Timeline

sepavloff created this revision.Jun 9 2021, 5:20 AM
sepavloff requested review of this revision.Jun 9 2021, 5:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2021, 5:20 AM
Herald added a subscriber: wdng. · View Herald Transcript
spatel accepted this revision.Jun 9 2021, 8:30 AM

LGTM - thanks!

But would it be better to push this first since it is an extension to the existing functionality, then add the changes for constrained ops on top of this?

This revision is now accepted and ready to land.Jun 9 2021, 8:30 AM
sepavloff updated this revision to Diff 350955.Jun 9 2021, 10:58 AM

Swap sequence of patches

Thanks!

But would it be better to push this first since it is an extension to the existing functionality, then add the changes for constrained ops on top of this?

No problem, updated the patch accordingly.

This revision was landed with ongoing or failed builds.Jun 9 2021, 9:58 PM
This revision was automatically updated to reflect the committed changes.