Page MenuHomePhabricator

[mlir][tosa] Temporarily support 2D and 3D tensor types in matmul
ClosedPublic

Authored by sjarus on Jun 7 2021, 4:41 PM.

Details

Summary

Temporarily support 2D and 3D while the TOSA Matmul op is updated to support batched operations.

Diff Detail

Event Timeline

sjarus created this revision.Jun 7 2021, 4:41 PM
sjarus requested review of this revision.Jun 7 2021, 4:41 PM

Something appears to be wrong with your patch as its based on a revision not in the LLVM tree. Could you verify your diff history or resubmit based on head?

sjarus added a comment.EditedJun 8 2021, 12:55 PM

Something appears to be wrong with your patch as its based on a revision not in the LLVM tree. Could you verify your diff history or resubmit based on head?

Yeah I noticed I did arc diff from a different branch.

Edit: I think I had a stale branch.

sjarus updated this revision to Diff 350702.Jun 8 2021, 1:29 PM

Temporarily support 2D and 3D tensor types as valid.
Legalizations and tests across multiple repositories must be updated to emit 3D type.
Change to supporting just Tosa_Tensor3D once everything is updated.

Looks good, I am just checking why the windows build failed (and whether its unrelated).

rsuderman edited the summary of this revision. (Show Details)Jun 8 2021, 3:13 PM

Updated description as external projects are not relevant for LLVM updates.

sjarus added a comment.Jun 8 2021, 3:43 PM

Looks good, I am just checking why the windows build failed (and whether its unrelated).

Thanks a lot for your assistance!

rsuderman accepted this revision.Jun 8 2021, 3:57 PM
This revision is now accepted and ready to land.Jun 8 2021, 3:57 PM
This revision was landed with ongoing or failed builds.Jun 8 2021, 4:06 PM
This revision was automatically updated to reflect the committed changes.