Page MenuHomePhabricator

[mlir-lsp-server] Add support for textDocument/documentSymbols
ClosedPublic

Authored by rriddle on Jun 4 2021, 5:07 PM.

Details

Summary

This allows for building an outline of the symbols and symbol tables within the IR. This allows for easy navigations to functions/modules and other symbol/symbol table operations within the IR.

Depends On D103728

Diff Detail

Unit TestsFailed

TimeTest
20 msx64 debian > MLIR.mlir-lsp-server::document-symbols.test
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-lsp-server -lit-test < /var/lib/buildkite-agent/builds/llvm-project/mlir/test/mlir-lsp-server/document-symbols.test | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck -strict-whitespace /var/lib/buildkite-agent/builds/llvm-project/mlir/test/mlir-lsp-server/document-symbols.test
840 msx64 windows > MLIR.mlir-lsp-server::document-symbols.test
Script: -- : 'RUN: at line 1'; c:\ws\w7\llvm-project\premerge-checks\build\bin\mlir-lsp-server.exe -lit-test < C:\ws\w7\llvm-project\premerge-checks\mlir\test\mlir-lsp-server\document-symbols.test | c:\ws\w7\llvm-project\premerge-checks\build\bin\filecheck.exe -strict-whitespace C:\ws\w7\llvm-project\premerge-checks\mlir\test\mlir-lsp-server\document-symbols.test

Event Timeline

rriddle created this revision.Jun 4 2021, 5:07 PM
rriddle requested review of this revision.Jun 4 2021, 5:07 PM
jpienaar accepted this revision.Jun 10 2021, 9:59 AM

Looks good overall thanks

mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
634

Nit: I'd have this inside the else (the indenting here looks weird else as makes it feel like it is attached to block above).

mlir/lib/Tools/mlir-lsp-server/lsp/Protocol.h
476

OOC are these just default LSP ones?

This revision is now accepted and ready to land.Jun 10 2021, 9:59 AM
rriddle marked 2 inline comments as done.Jun 10 2021, 10:22 AM
rriddle added inline comments.
This revision was landed with ongoing or failed builds.Jun 10 2021, 11:03 AM
This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.