Page MenuHomePhabricator

[mlir-lsp-server] Add support for hover on symbol references
ClosedPublic

Authored by rriddle on Jun 4 2021, 5:06 PM.

Details

Summary

For now the hover simply shows the same information as hovering on the operation
name. If necessary this can be tweaked to something symbol specific later.

Depends On D103727

Diff Detail

Event Timeline

rriddle created this revision.Jun 4 2021, 5:06 PM
rriddle requested review of this revision.Jun 4 2021, 5:06 PM
jpienaar accepted this revision.Jun 7 2021, 8:08 AM
jpienaar added inline comments.
mlir/test/mlir-lsp-server/hover.test
145

Why does this add at 4? For the symbol ref we just highlight func?

This revision is now accepted and ready to land.Jun 7 2021, 8:08 AM
rriddle marked an inline comment as done.Jun 7 2021, 1:51 PM
rriddle added inline comments.
mlir/test/mlir-lsp-server/hover.test
145

Oops, thanks for the catch.

This revision was landed with ongoing or failed builds.Jun 7 2021, 2:10 PM
This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.