This revision adds support for hover on region operations, by temporarily removing the regions during printing. This revision also tweaks the hover format for operations to include symbol information, now that FuncOp can be shown in the hover.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/test/mlir-lsp-server/hover.test | ||
---|---|---|
117 | Would have been nice if we could have { ... } here instead to be able to differentiate from an empty body or not. But that would require more invasive changes. ... Mmm, well we could add a op with a custom printer (which doesn't parse back :)) and then this region is just the "ElidedRegion" with the elided op. |
mlir/test/mlir-lsp-server/hover.test | ||
---|---|---|
117 | Yeah, I think if we end up with a desire to support this in general we should add a printer flag that elides the region. |
Would have been nice if we could have { ... } here instead to be able to differentiate from an empty body or not. But that would require more invasive changes. ... Mmm, well we could add a op with a custom printer (which doesn't parse back :)) and then this region is just the "ElidedRegion" with the elided op.