For now the hover simply shows the same information as hovering on the operation
name. If necessary this can be tweaked to something symbol specific later.
Depends On D103727
Paths
| Differential D103728
[mlir-lsp-server] Add support for hover on symbol references ClosedPublic Authored by rriddle on Jun 4 2021, 5:06 PM.
Details Summary For now the hover simply shows the same information as hovering on the operation Depends On D103727
Diff Detail
Event TimelineHerald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptJun 4 2021, 5:06 PM rriddle added a child revision: D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.Jun 4 2021, 5:07 PM This revision is now accepted and ready to land.Jun 7 2021, 8:08 AM This revision was landed with ongoing or failed builds.Jun 7 2021, 2:10 PM Closed by commit rG4c3adea7a4ab: [mlir-lsp-server] Add support for hover on symbol references (authored by rriddle). · Explain Why This revision was automatically updated to reflect the committed changes. rriddle marked an inline comment as done.
Revision Contents
Diff 349996 mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
mlir/test/mlir-lsp-server/hover.test
|
Why does this add at 4? For the symbol ref we just highlight func?