ArmSVE-specific memory operations are needed to generate end-to-end
code for as long as MLIR core doesn't support scalable vectors. This
instructions will be eventually unnecessary, for now they're required
for more complex testing.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/ArmSVE/Transforms/LegalizeForLLVMExport.cpp | ||
---|---|---|
123–126 | I don't think this works. Derived patterns never call this function and override matchAndRewrite, the default implementation of which would have called match then rewrite, but it is not called either. |
mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td | ||
---|---|---|
379 | s/on/to/ |
mlir/lib/Dialect/ArmSVE/Transforms/LegalizeForLLVMExport.cpp | ||
---|---|---|
123–126 | This should fix it, now I make sure that the check is performed in the readAndRewrite method. |
s/on/to/