Page MenuHomePhabricator

[AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR.
AcceptedPublic

Authored by aemerson on Thu, May 27, 11:51 PM.

Details

Reviewers
arsenm
paquette
Summary

Currently we can't fully legalize the AArch64 test for this, that support will be coming in the form of an additional artifact combiner in a later patch.

Diff Detail

Unit TestsFailed

TimeTest
20 msx64 debian > LLVM-Unit.CodeGen/GlobalISel/_/GlobalISelTests::AArch64GISelMITest.moreElementsShuffle
Script: -- /var/lib/buildkite-agent/builds/llvm-project/build/unittests/CodeGen/GlobalISel/./GlobalISelTests --gtest_filter=AArch64GISelMITest.moreElementsShuffle
40 msx64 debian > LLVM.CodeGen/AArch64/GlobalISel::legalize-shuffle-vector-wip.mir
Script: -- : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -mtriple=aarch64 -O0 -run-pass=legalizer -global-isel-abort=2 /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir -o - | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir
20 msx64 windows > LLVM-Unit.CodeGen/GlobalISel/_/GlobalISelTests_exe::AArch64GISelMITest.moreElementsShuffle
Script: -- C:\ws\w16-1\llvm-project\premerge-checks\build\unittests\CodeGen\GlobalISel\.\GlobalISelTests.exe --gtest_filter=AArch64GISelMITest.moreElementsShuffle
80 msx64 windows > LLVM.CodeGen/AArch64/GlobalISel::legalize-shuffle-vector-wip.mir
Script: -- : 'RUN: at line 2'; c:\ws\w16-1\llvm-project\premerge-checks\build\bin\llc.exe -mtriple=aarch64 -O0 -run-pass=legalizer -global-isel-abort=2 C:\ws\w16-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\GlobalISel\legalize-shuffle-vector-wip.mir -o - | c:\ws\w16-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\GlobalISel\legalize-shuffle-vector-wip.mir

Event Timeline

aemerson created this revision.Thu, May 27, 11:51 PM
aemerson requested review of this revision.Thu, May 27, 11:51 PM
paquette added inline comments.Fri, Jun 4, 1:15 PM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
4848

static cast?

llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir
2

-verify-machineinstrs?

11

might as well drop the liveins and other similar cruft?

llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
4053

is this an unfinished comment?

paquette accepted this revision.Fri, Jun 4, 1:16 PM

all my comments were pretty minor so LGTM

This revision is now accepted and ready to land.Fri, Jun 4, 1:16 PM