This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR.
ClosedPublic

Authored by aemerson on May 27 2021, 11:51 PM.

Details

Summary

Currently we can't fully legalize the AArch64 test for this, that support will be coming in the form of an additional artifact combiner in a later patch.

Diff Detail

Event Timeline

aemerson created this revision.May 27 2021, 11:51 PM
aemerson requested review of this revision.May 27 2021, 11:51 PM
paquette added inline comments.Jun 4 2021, 1:15 PM
llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
4908

static cast?

llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir
2 ↗(On Diff #348449)

-verify-machineinstrs?

11 ↗(On Diff #348449)

might as well drop the liveins and other similar cruft?

llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp
4053

is this an unfinished comment?

paquette accepted this revision.Jun 4 2021, 1:16 PM

all my comments were pretty minor so LGTM

This revision is now accepted and ready to land.Jun 4 2021, 1:16 PM
This revision was landed with ongoing or failed builds.Jul 10 2021, 12:25 AM
This revision was automatically updated to reflect the committed changes.