[libcxx][ranges] Add `ranges::empty_view`.

[cjdb]

Please add iterator and range conformance tests. Will LGTM after that.

[Mordante]

LGTM modulo the open review comments.

libcxx/include/__ranges/empty_view.h

3

Update or remove the filename.

[ldionne]

LGTM pending CI and other review comments.

libcxx/include/__ranges/empty_view.h

3

Please remove.

[zoecarver]

• Rebase
• Remove comment
• Add conformance tests

libcxx/test/std/ranges/range.adaptors/range.empty/empty_view.pass.cpp

25

@cjdb are these good or did you want any others?

libcxx/docs/OneRangesProposalStatus.csv

 [range.subrange],,[view.interface],Zoe Carver,`D102006 <https://llvm.org/D102006>`_,
 [range.all],view::all,"[range.subrange], [range.view.ref]",Zoe Carver,`D102028 <https://llvm.org/D102028>`_,
 [range.view.ref],ref-view,[view.interface],Zoe Carver,`D102020 <https://llvm.org/D102020>`_,
 [range.filter],filter_view,[range.all],Louis Dionne,,
 [range.transform],transform_view,[range.all],Zoe Carver,,
 [range.iota],iota_view,[range.all],Louis Dionne,,
 [range.take],take_view,[range.all],Zoe Carver,,
 [range.join],join_view,[range.all],Christopher Di Bella,,
-[range.empty],empty_view,[view.interface],Zoe Carver,,
+[range.empty],empty_view,[view.interface],Zoe Carver,,✅
 [range.single],single_view,[view.interface],,,
 [range.split],split_view,[range.all],,,
 [range.counted],view::counted,[range.subrange],,,
 [range.common],common_view,[range.all],Zoe Carver,,
 [range.reverse],reverse_view,[range.all],,,

libcxx/include/CMakeLists.txt

set(files
   __memory/unique_ptr.h
   __mutex_base
   __node_handle
   __nullptr
   __ranges/access.h
   __ranges/concepts.h
   __ranges/data.h
   __ranges/empty.h
+  __ranges/empty_view.h
   __ranges/enable_borrowed_range.h
   __ranges/view_interface.h
   __ranges/view.h
   __ranges/size.h
   __split_buffer
   __std_stream
   __string
   __threading_support

libcxx/include/__ranges/empty_view.h

+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#ifndef _LIBCPP___RANGES_EMPTY_VIEW_H
+#define _LIBCPP___RANGES_EMPTY_VIEW_H
+
+#include <__config>
+#include <__ranges/view_interface.h>
+
+#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
+#pragma GCC system_header
+#endif
+
+_LIBCPP_PUSH_MACROS
+#include <__undef_macros>
+
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+#if !defined(_LIBCPP_HAS_NO_RANGES)
+
+namespace ranges {
+  template<class _Tp>
+    requires is_object_v<_Tp>
+  class empty_view : public view_interface<empty_view<_Tp>> {
+  public:
+    static constexpr _Tp* begin() noexcept { return nullptr; }
+    static constexpr _Tp* end() noexcept { return nullptr; }
+    static constexpr _Tp* data() noexcept { return nullptr; }
+    static constexpr size_t size() noexcept { return 0; }
+    static constexpr bool empty() noexcept { return true; }
+  };
+} // namespace ranges
+
+#endif // !defined(_LIBCPP_HAS_NO_RANGES)
+
+_LIBCPP_END_NAMESPACE_STD
+
+_LIBCPP_POP_MACROS
+
+#endif // _LIBCPP___RANGES_EMPTY_VIEW_H

libcxx/include/ranges

namespace std::ranges {
 
   template <class _Tp>
     concept common_range = see below;
 
   // [view.interface], class template view_interface
   template<class D>
     requires is_class_v<D> && same_as<D, remove_cv_t<D>>
   class view_interface;
+
+  // [range.empty], empty view
+  template<class T>
+    requires is_object_v<T>
+  class empty_view;
 }
 
 */
 
 #include <__config>
 #include <__ranges/access.h>
 #include <__ranges/concepts.h>
 #include <__ranges/data.h>
 #include <__ranges/empty.h>
+#include <__ranges/empty_view.h>
 #include <__ranges/enable_borrowed_range.h>
 #include <__ranges/size.h>
 #include <__ranges/view_interface.h>
 #include <__ranges/view.h>
 #include <compare>          // Required by the standard.
 #include <initializer_list> // Required by the standard.
 #include <iterator>         // Required by the standard.
 #include <type_traits>

libcxx/test/std/ranges/range.adaptors/range.empty/empty_view.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: libcpp-no-concepts
+// UNSUPPORTED: gcc-10
+
+// template<class T>
+// class empty_view;
+
+#include <ranges>
+#include <cassert>
+
+#include "test_macros.h"
+
+template<class T>
+constexpr void testType() {
+  static_assert(std::ranges::range<std::ranges::empty_view<T>>);
+  static_assert(std::ranges::range<const std::ranges::empty_view<T>>);
+  static_assert(std::ranges::view<std::ranges::empty_view<T>>);
+
+  std::ranges::empty_view<T> empty;
+
+  assert(empty.begin() == nullptr);
+  assert(empty.end() == nullptr);
+  assert(empty.data() == nullptr);
+  assert(empty.size() == 0);
+  assert(empty.empty() == true);
+
+  assert(std::ranges::begin(empty) == nullptr);
+  assert(std::ranges::end(empty) == nullptr);
+  assert(std::ranges::data(empty) == nullptr);
+  assert(std::ranges::size(empty) == 0);
+  assert(std::ranges::empty(empty) == true);
+}
+
+struct Empty {};
+struct BigType { char buff[8]; };
+
+template<class T>
+concept ValidEmptyView = requires { typename std::ranges::empty_view<T>; };
+
+constexpr bool test() {
+  // Not objects:
+  static_assert(!ValidEmptyView<int&>);
+  static_assert(!ValidEmptyView<void>);
+
+  testType<int>();
+  testType<const int>();
+  testType<int*>();
+  testType<Empty>();
+  testType<const Empty>();
+  testType<BigType>();
+
+  return true;
+}
+
+int main(int, char**) {
+  test();
+  static_assert(test());
+
+  return 0;
+}