Depends On D103102
Not yet implemented:
- Error handling after synchronous await
- Error handling for async groups
Will be addressed in the followup PRs
Paths
| Differential D103109
[mlir] Add error state and error propagation to async runtime values ClosedPublic Authored by ezhulenev on May 25 2021, 12:08 PM.
Details Summary Depends On D103102 Not yet implemented:
Will be addressed in the followup PRs
Diff Detail
Event Timelinemehdi_amini added inline comments.
This revision is now accepted and ready to land.May 25 2021, 2:15 PM ezhulenev marked an inline comment as done. Comment ActionsUpdate is_error op definition to reject async.group operands
ezhulenev added a child revision: D103203: [mlir] Async: Add error propagation support to async groups.May 26 2021, 1:33 PM This revision was landed with ongoing or failed builds.May 27 2021, 9:28 AM Closed by commit rG39957aa4243c: [mlir] Add error state and error propagation to async runtime values (authored by ezhulenev). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 348307 mlir/include/mlir/Dialect/Async/IR/AsyncOps.td
mlir/include/mlir/ExecutionEngine/AsyncRuntime.h
mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp
mlir/lib/ExecutionEngine/AsyncRuntime.cpp
mlir/test/Conversion/AsyncToLLVM/convert-runtime-to-llvm.mlir
mlir/test/Dialect/Async/async-to-async-runtime.mlir
mlir/test/Dialect/Async/runtime.mlir
mlir/test/mlir-cpu-runner/async-error.mlir
|
What else would the verifier allow?