This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add error state and error propagation to async runtime values
ClosedPublic

Authored by ezhulenev on May 25 2021, 12:08 PM.

Details

Summary

Depends On D103102

Not yet implemented:

  1. Error handling after synchronous await
  2. Error handling for async groups

Will be addressed in the followup PRs

Diff Detail

Event Timeline

ezhulenev created this revision.May 25 2021, 12:08 PM
ezhulenev requested review of this revision.May 25 2021, 12:08 PM
ezhulenev edited the summary of this revision. (Show Details)May 25 2021, 12:10 PM
ezhulenev added a reviewer: mehdi_amini.
mehdi_amini accepted this revision.May 25 2021, 2:15 PM
mehdi_amini added inline comments.
mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
685

What else would the verifier allow?

This revision is now accepted and ready to land.May 25 2021, 2:15 PM
ezhulenev updated this revision to Diff 347797.May 25 2021, 3:03 PM
ezhulenev marked an inline comment as done.

Update is_error op definition to reject async.group operands

mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
685

Updated op definition to reject async.group values

ezhulenev updated this revision to Diff 347798.May 25 2021, 3:06 PM

Fix verifier error

This revision was landed with ongoing or failed builds.May 27 2021, 9:28 AM
This revision was automatically updated to reflect the committed changes.