This is an archive of the discontinued LLVM Phabricator instance.

[3/4][mlir][doc] Fix links and references in documentation of Tutorials
ClosedPublic

Authored by zero9178 on May 24 2021, 6:26 AM.

Details

Summary

This patch is the third in a series of patches fixing markdown links and references inside the mlir documentation. For the first see https://reviews.llvm.org/D103011. They are not dependent on each other however.

This patch addresses all broken references to other markdown files and sections inside the Tutorials folder.

Diff Detail

Event Timeline

zero9178 created this revision.May 24 2021, 6:26 AM
zero9178 requested review of this revision.May 24 2021, 6:26 AM

LGTM! Just a NIT regarding [TensorType].

mlir/docs/Tutorials/Toy/Ch-2.md
244–245

I know this about fixing the links, but shouldn't [TensorType] be changed to RankedTensorType?

zero9178 updated this revision to Diff 347661.May 25 2021, 6:06 AM

Changed links named "TensorType" to "RankedTensorType".

In particular there were 3 occurrences at:
Ch-2.md:245
Ch-5.md:18
Ch-5.md:100

@marbre could you double check whether those make sense in their respective contexts?

rriddle accepted this revision.May 25 2021, 10:45 AM

Thanks!

mlir/docs/Tutorials/Toy/Ch-5.md
18–23

This should still be tensor type.

100–102

These should be tensor type.

This revision is now accepted and ready to land.May 25 2021, 10:45 AM
This revision was landed with ongoing or failed builds.May 25 2021, 11:19 AM
This revision was automatically updated to reflect the committed changes.
zero9178 marked 2 inline comments as done.

Addressed review comments in final commit