Surface clone APIs in CAPI

[GeorgeLyon]

Fix comment

[GeorgeLyon]

Test

[GeorgeLyon]

Test

[mehdi_amini]

mlir/include/mlir-c/IR.h

199 ↗

(On Diff #347266)

Since we can turn a Module into an Operation, should we avoid duplicating every single method on operation to take directly a module as well?

332 ↗

(On Diff #347266)

333 ↗

(On Diff #347266)

mlir/test/CAPI/ir.c

1656

[GeorgeLyon]

• Address feedback

[GeorgeLyon]

mlir/include/mlir-c/IR.h

199 ↗

(On Diff #347266)

Generally I would agree, but in this case the issue is we cannot create a module from an operation.

[mehdi_amini]

mlir/include/mlir-c/IR.h

199 ↗

(On Diff #347266)

mlirModuleFromOperation line 217?

[GeorgeLyon]

• Remove mlirModuleClone

mlir/include/mlir-c/IR.h

199 ↗

(On Diff #347266)

Whoops, missed this API. Thanks!

[GeorgeLyon]

• Remove suprious function

mlir/test/CAPI/ir.c

intptr_t countOperations(MlirBlock block) {
   MlirOperation op = mlirBlockGetFirstOperation(block);
   while (!mlirOperationIsNull(op)) {
     op = mlirOperationGetNextInBlock(op);
     count++;
   }
   return count;
 }
 
-/// Tests operand APIs.
+/// Tests clone APIs.
 int testClone() {
   fprintf(stderr, "@testClone\n");
   // CHECK-LABEL: @testClone
 
   MlirContext ctx = mlirContextCreate();
   MlirLocation loc = mlirLocationUnknownGet(ctx);
   MlirModule module = mlirModuleCreateEmpty(loc);
   MlirBlock body = mlirModuleGetBody(module);
   MlirType indexType = mlirIndexTypeGet(ctx);
 
   // Create a constant
   MlirAttribute indexOneLiteral =
       mlirAttributeParseGet(ctx, mlirStringRefCreateFromCString("1 : index"));
   MlirNamedAttribute indexOneValueAttr = mlirNamedAttributeGet(
       mlirIdentifierGet(ctx, mlirStringRefCreateFromCString("value")),
       indexOneLiteral);
   MlirOperationState constOneState = mlirOperationStateGet(
       mlirStringRefCreateFromCString("std.constant"), loc);
   mlirOperationStateAddResults(&constOneState, 1, &indexType);
   mlirOperationStateAddAttributes(&constOneState, 1, &indexOneValueAttr);
   MlirOperation constOne = mlirOperationCreate(&constOneState);
-  
   // Replace the original const one with a clone and destroy the original
   MlirOperation evilConstOne = mlirOperationClone(constOne);
   mlirOperationDestroy(constOne);
   constOne = evilConstOne;
 
   // Check that modifying a module does not modify its clone
   MlirModule moduleClone = mlirModuleClone(module);
   MlirBlock cloneBody = mlirModuleGetBody(moduleClone);
   mlirBlockAppendOwnedOperation(body, constOne);