This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add support for fusion into TiledLoopOp.
ClosedPublic

Authored by pifon2a on May 18 2021, 1:31 PM.

Diff Detail

Event Timeline

pifon2a created this revision.May 18 2021, 1:31 PM
pifon2a requested review of this revision.May 18 2021, 1:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2021, 1:31 PM
gysit added inline comments.May 21 2021, 8:17 AM
mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
146–147

Could an assert(resultInputOperand XOR resultOutputOperand) make sense? Or is that obvious from the context?

157

I believe this can go away?

gysit accepted this revision.May 21 2021, 8:30 AM
This revision is now accepted and ready to land.May 21 2021, 8:30 AM
gysit added inline comments.May 21 2021, 8:37 AM
mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
728

Nit: A newline is missing.

Plus I think you could use llvm::find instead of llvm::find_if and avoid the lambda?

pifon2a updated this revision to Diff 347049.May 21 2021, 8:54 AM
pifon2a marked an inline comment as done.

Address the comments.

pifon2a updated this revision to Diff 347050.May 21 2021, 8:57 AM

Remove empty line

pifon2a marked 2 inline comments as done.May 21 2021, 8:58 AM
pifon2a added inline comments.
mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
157

ahaha, of course.

pifon2a updated this revision to Diff 347054.May 21 2021, 9:13 AM
pifon2a marked an inline comment as done.

Rebase

This revision was landed with ongoing or failed builds.May 21 2021, 9:14 AM
This revision was automatically updated to reflect the committed changes.