This is an archive of the discontinued LLVM Phabricator instance.

[debuginfo-tests] Stop using installed LLDB and remove redundancy
ClosedPublic

Authored by jhenderson on May 18 2021, 3:12 AM.

Details

Summary

The removed code just replicated what use_llvm_tool does, plus looked for an installed LLDB on the PATH to use. In a monorepo world, it seems likely that if people want to run the tests that require LLDB, they should enable and build LLDB itself. If users really want to use the installed LLDB executable, they can specify the path to the executable as an environment variable "LLDB".

See the discussion in https://reviews.llvm.org/D95339#2638619 for more details.

Diff Detail

Event Timeline

jhenderson requested review of this revision.May 18 2021, 3:12 AM
jhenderson created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2021, 3:12 AM

This works fine with our workflow at least, so a soft LGTM from me. I'd suggest waiting for a couple of days for more feedback though.

aprantl accepted this revision.May 21 2021, 7:25 PM

If the intended effect is that we run the debuginfo-tests against the just-built LLDB this change makes sense to me in a monorepo world. Conditional LGTM from me.

This revision is now accepted and ready to land.May 21 2021, 7:25 PM

If the intended effect is that we run the debuginfo-tests against the just-built LLDB this change makes sense to me in a monorepo world. Conditional LGTM from me.

Thanks, yes that's the intended effect of this change. It's been a few days now, so I'll land this change.