Page MenuHomePhabricator

[libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing.
Needs ReviewPublic

Authored by sfertile on May 17 2021, 8:26 AM.

Details

Reviewers
ldionne
jasonliu
xingxue
daltenty
Group Reviewers
Restricted Project
Summary

Adds a target info for local AIX testing, and adjusts some of the link option to enable running testing on AIX for libcxx, libcxxabi and libunwind.

Diff Detail

Event Timeline

sfertile created this revision.May 17 2021, 8:26 AM
sfertile requested review of this revision.May 17 2021, 8:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2021, 8:26 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

LGTM on AIX perspective.
FYI, we will need two reviewers from libc++ review group or the maintainer of libc++ project to approve before we could land.

libcxx/utils/libcxx/test/target_info.py
163

Just noting that this setup only works when we use libc++/libc++abi/libunwind stack.
In theory, libc++ could work with gcc and use what's in libstdc++ to replace libc++abi and libunwind. If that's the case, then this won't work any more. And we would need something similar to LinuxLocalTI above.
But I guess people have intention to make the above combination work could change this setup later when they needed.

jasonliu accepted this revision.Fri, May 28, 11:26 AM