Page MenuHomePhabricator

Fixed llvm-objcopy to add correct symbol table for ELF with program headers.
ClosedPublic

Authored by aorlov on May 11 2021, 10:36 AM.

Diff Detail

Event Timeline

aorlov created this revision.May 11 2021, 10:36 AM
aorlov requested review of this revision.May 11 2021, 10:36 AM
jhenderson accepted this revision.May 12 2021, 12:43 AM

LGTM, with nit.

llvm/test/tools/llvm-objcopy/ELF/add-symbol-no-symtab.test
109

The name ProgramHeaders (i.e. with that specific spelling) is specific to the YAML, but the actual issue is to do with program headers in general in the object.

This revision is now accepted and ready to land.May 12 2021, 12:43 AM