Page MenuHomePhabricator

aorlov (Alex Orlov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2019, 1:07 PM (87 w, 4 d)

Recent Activity

Thu, May 20

aorlov committed rG752385b128e4: Add support for DWARF embedded source to llvm-symbolizer. (authored by aorlov).
Add support for DWARF embedded source to llvm-symbolizer.
Thu, May 20, 10:41 AM
aorlov closed D102355: Add support for DWARF embedded source to llvm-symbolizer.
Thu, May 20, 10:40 AM · Restricted Project

May 18 2021

aorlov updated the diff for D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 18 2021, 4:20 PM · Restricted Project
aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Simplified the solution. Replaced RemoveDiagnosticsFromPool with SuppressAccessChecks.
@krisb, please, look.

May 18 2021, 3:53 PM · Restricted Project, Restricted Project
aorlov committed rG4fedb3a613a3: [symbolizer] Added StartAddress for the resolved function. (authored by aorlov).
[symbolizer] Added StartAddress for the resolved function.
May 18 2021, 3:39 PM
aorlov closed D102316: [symbolizer] Added StartAddress for the resolved function..
May 18 2021, 3:38 PM · Restricted Project

May 17 2021

aorlov updated the diff for D102316: [symbolizer] Added StartAddress for the resolved function..
May 17 2021, 1:04 PM · Restricted Project
aorlov updated the diff for D102316: [symbolizer] Added StartAddress for the resolved function..
May 17 2021, 12:46 PM · Restricted Project
aorlov updated the diff for D102316: [symbolizer] Added StartAddress for the resolved function..
May 17 2021, 8:47 AM · Restricted Project
aorlov updated the diff for D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 17 2021, 7:45 AM · Restricted Project

May 16 2021

aorlov updated the diff for D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 16 2021, 12:37 PM · Restricted Project
aorlov added inline comments to D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 16 2021, 11:31 AM · Restricted Project
aorlov added inline comments to D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 16 2021, 12:45 AM · Restricted Project
aorlov added inline comments to D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 16 2021, 12:35 AM · Restricted Project
aorlov updated the diff for D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 16 2021, 12:27 AM · Restricted Project

May 15 2021

aorlov updated the diff for D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 15 2021, 1:44 PM · Restricted Project
aorlov committed rG88a8965a7d93: NFC. Refactored DIPrinter for support embedded source. (authored by aorlov).
NFC. Refactored DIPrinter for support embedded source.
May 15 2021, 12:01 PM
aorlov closed D102539: NFC. Refactored DIPrinter for support embedded source..
May 15 2021, 12:01 PM · Restricted Project

May 14 2021

aorlov updated the diff for D102316: [symbolizer] Added StartAddress for the resolved function..
May 14 2021, 4:12 PM · Restricted Project
aorlov added a comment to D102355: Add support for DWARF embedded source to llvm-symbolizer.

https://reviews.llvm.org/D102539

May 14 2021, 3:27 PM · Restricted Project
aorlov requested review of D102539: NFC. Refactored DIPrinter for support embedded source..
May 14 2021, 3:26 PM · Restricted Project
aorlov added a comment to D102316: [symbolizer] Added StartAddress for the resolved function..

Of course I though about multiple ranges case. And preferred keeping it simple for the beginning. This patch does not print StartAddress if DW_AT_low_pc is missing. That’s the case #1 in the above list of options. As already mentioned, in case of multiple ranges we do not know for sure where a function starts, at least not without an extra analyses of the code. We will need more solid use case and samples to move to that direction. Not a subject of this patch.

May 14 2021, 11:44 AM · Restricted Project

May 13 2021

aorlov added a comment to D102316: [symbolizer] Added StartAddress for the resolved function..

it could just be part of the verbose output (since that is where the StartLine output is printed.

May 13 2021, 12:33 PM · Restricted Project

May 12 2021

aorlov requested review of D102355: Add support for DWARF embedded source to llvm-symbolizer.
May 12 2021, 12:41 PM · Restricted Project
aorlov updated the diff for D102316: [symbolizer] Added StartAddress for the resolved function..
May 12 2021, 1:49 AM · Restricted Project
aorlov committed rGd8e65585f7c7: Fixed llvm-objcopy to add correct symbol table for ELF with program headers. (authored by aorlov).
Fixed llvm-objcopy to add correct symbol table for ELF with program headers.
May 12 2021, 1:40 AM
aorlov closed D102258: Fixed llvm-objcopy to add correct symbol table for ELF with program headers..
May 12 2021, 1:39 AM · Restricted Project
aorlov requested review of D102316: [symbolizer] Added StartAddress for the resolved function..
May 12 2021, 1:16 AM · Restricted Project

May 11 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Please make another commit to fix the unnecessary introduction of semi-colons in the places I've highlighted.

May 11 2021, 1:48 PM · Restricted Project
aorlov committed rGebdcebfcb4b5: Removed unnecessary introduction of semi-colons. (authored by aorlov).
Removed unnecessary introduction of semi-colons.
May 11 2021, 1:46 PM
aorlov requested review of D102258: Fixed llvm-objcopy to add correct symbol table for ELF with program headers..
May 11 2021, 10:36 AM · Restricted Project
aorlov committed rG05d1ae4e18fa: * Add support for JSON output style to llvm-symbolizer (authored by aorlov).
* Add support for JSON output style to llvm-symbolizer
May 11 2021, 2:11 AM
aorlov closed D96883: Add support for JSON output style to llvm-symbolizer.
May 11 2021, 2:11 AM · Restricted Project

May 10 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

I have added the aarch64 requirements, and a few comments in that test for target offsets. Hope this should address it.

May 10 2021, 1:32 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 10 2021, 1:29 PM · Restricted Project
aorlov added inline comments to D96883: Add support for JSON output style to llvm-symbolizer.
May 10 2021, 11:35 AM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 10 2021, 11:33 AM · Restricted Project

May 9 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.

I have replaced output-style-json-frame.test with output-style-json-frame.ll, which is much friendlier but still contains non-zero TagOffset.

May 9 2021, 11:42 AM · Restricted Project

May 7 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 7 2021, 5:14 AM · Restricted Project

May 6 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 6 2021, 8:56 AM · Restricted Project

May 5 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

I think adding source context can be a later patch. Let's try to avoid adding more than we have to in this one patch.

May 5 2021, 2:31 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 5 2021, 2:15 PM · Restricted Project

May 4 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Ping.

May 4 2021, 10:11 AM · Restricted Project

May 2 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
May 2 2021, 2:34 PM · Restricted Project

Apr 30 2021

aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

@krisb
Thanks for the review.

Apr 30 2021, 10:17 AM · Restricted Project, Restricted Project

Apr 27 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 27 2021, 9:50 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.

Used --print-source-context-lines to control Source printout in JSON.

Apr 27 2021, 10:49 AM · Restricted Project
aorlov added inline comments to D96883: Add support for JSON output style to llvm-symbolizer.
Apr 27 2021, 9:49 AM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 27 2021, 9:41 AM · Restricted Project

Apr 25 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Ping.

Apr 25 2021, 10:01 AM · Restricted Project

Apr 23 2021

aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Updated. @krisb, please, verify.

Apr 23 2021, 10:11 AM · Restricted Project, Restricted Project
aorlov updated the diff for D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Apr 23 2021, 10:04 AM · Restricted Project, Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 23 2021, 2:01 AM · Restricted Project

Apr 22 2021

aorlov added inline comments to D96883: Add support for JSON output style to llvm-symbolizer.
Apr 22 2021, 3:13 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 22 2021, 3:02 PM · Restricted Project

Apr 21 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.

I disagree and still think the ErrorCode is needed for the proper error handling, even if it is arbitrary and inconsistent, which is the usual case everywhere anyway.
I see your point, though, and did what you suggested to unblock this patch and get it committed.

Apr 21 2021, 10:38 AM · Restricted Project
aorlov added inline comments to D96883: Add support for JSON output style to llvm-symbolizer.
Apr 21 2021, 8:57 AM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 21 2021, 8:50 AM · Restricted Project

Apr 20 2021

aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

I do not think we should always include everything and anything into JSON. There is nothing wrong with skipping parameters with unknown values, not applicable data and such.

Apr 20 2021, 5:00 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 20 2021, 4:53 PM · Restricted Project

Apr 15 2021

aorlov committed rG49cbf4cd85a9: Fix bug in .eh_frame/.debug_frame PC offset calculation for DW_EH_PE_pcrel (authored by aorlov).
Fix bug in .eh_frame/.debug_frame PC offset calculation for DW_EH_PE_pcrel
Apr 15 2021, 4:06 AM
aorlov closed D100328: Fix bug in .eh_frame/.debug_frame PC offset calculation for DW_EH_PE_pcrel.
Apr 15 2021, 4:06 AM · Restricted Project

Apr 14 2021

aorlov added inline comments to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).
Apr 14 2021, 4:27 AM · Restricted Project, Restricted Project
aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

Do we still need the following tests:

  • clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp
  • clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp

?

Apr 14 2021, 4:25 AM · Restricted Project, Restricted Project
aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

One more ping.

Apr 14 2021, 4:17 AM · Restricted Project

Apr 12 2021

aorlov updated the diff for D100328: Fix bug in .eh_frame/.debug_frame PC offset calculation for DW_EH_PE_pcrel.
Apr 12 2021, 3:05 PM · Restricted Project
aorlov requested review of D100328: Fix bug in .eh_frame/.debug_frame PC offset calculation for DW_EH_PE_pcrel.
Apr 12 2021, 10:34 AM · Restricted Project
aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Ping.

Apr 12 2021, 9:22 AM · Restricted Project

Apr 9 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 9 2021, 12:06 PM · Restricted Project

Apr 8 2021

aorlov committed rGf47a4c071376: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right… (authored by aorlov).
[lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right…
Apr 8 2021, 6:30 PM
aorlov closed D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 8 2021, 6:29 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 8 2021, 4:48 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 8 2021, 4:24 PM · Restricted Project
aorlov added inline comments to D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 8 2021, 4:08 PM · Restricted Project
aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 8 2021, 4:03 PM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 8 2021, 2:12 PM · Restricted Project
aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

@krisb Thank you for your comments. I will consider them.

Apr 8 2021, 11:02 AM · Restricted Project, Restricted Project
aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 8 2021, 8:19 AM · Restricted Project
aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 8 2021, 8:11 AM · Restricted Project

Apr 7 2021

aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 7 2021, 3:30 PM · Restricted Project
aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 7 2021, 8:38 AM · Restricted Project

Apr 6 2021

aorlov committed rGc4c98c1b0a0c: Removed redundant code. (authored by aorlov).
Removed redundant code.
Apr 6 2021, 6:38 PM
aorlov updated the diff for D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 6 2021, 6:21 PM · Restricted Project
aorlov requested review of D99978: [lld] Fixed CodeView GuidAdapter::format to handle GUID bytes in the right order..
Apr 6 2021, 10:52 AM · Restricted Project
aorlov added a comment to D96883: Add support for JSON output style to llvm-symbolizer.

Note the build status is red because of a problem not related to this patch.

Apr 6 2021, 10:07 AM · Restricted Project
aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 6 2021, 3:22 AM · Restricted Project

Apr 5 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Apr 5 2021, 9:50 AM · Restricted Project
aorlov committed rG5f57793c4fe4: * NFC. Refactored DIPrinter for better support of new print styles. (authored by aorlov).
* NFC. Refactored DIPrinter for better support of new print styles.
Apr 5 2021, 4:41 AM
aorlov closed D98994: NFC. Refactored DIPrinter for better support of new print styles..
Apr 5 2021, 4:41 AM · Restricted Project

Apr 4 2021

aorlov updated the diff for D98994: NFC. Refactored DIPrinter for better support of new print styles..
Apr 4 2021, 8:50 AM · Restricted Project

Apr 3 2021

aorlov added inline comments to D98994: NFC. Refactored DIPrinter for better support of new print styles..
Apr 3 2021, 1:08 PM · Restricted Project
aorlov updated the diff for D98994: NFC. Refactored DIPrinter for better support of new print styles..
Apr 3 2021, 12:56 PM · Restricted Project

Apr 1 2021

aorlov added a comment to D98994: NFC. Refactored DIPrinter for better support of new print styles..

Ping.

Apr 1 2021, 11:43 AM · Restricted Project

Mar 31 2021

aorlov updated the diff for D98994: NFC. Refactored DIPrinter for better support of new print styles..
Mar 31 2021, 3:36 AM · Restricted Project

Mar 30 2021

aorlov added a comment to D98994: NFC. Refactored DIPrinter for better support of new print styles..

Just for the record.
The build status is red because of a problem not related to this patch.

Mar 30 2021, 1:58 PM · Restricted Project

Mar 29 2021

aorlov added inline comments to D98994: NFC. Refactored DIPrinter for better support of new print styles..
Mar 29 2021, 3:18 AM · Restricted Project
aorlov updated the diff for D98994: NFC. Refactored DIPrinter for better support of new print styles..
Mar 29 2021, 3:07 AM · Restricted Project

Mar 26 2021

aorlov added inline comments to D98994: NFC. Refactored DIPrinter for better support of new print styles..
Mar 26 2021, 1:29 PM · Restricted Project
aorlov updated the diff for D98994: NFC. Refactored DIPrinter for better support of new print styles..
Mar 26 2021, 1:24 PM · Restricted Project

Mar 24 2021

aorlov updated the diff for D96883: Add support for JSON output style to llvm-symbolizer.
Mar 24 2021, 1:08 PM · Restricted Project