This matches how they are defined on X86.
This should fix the relative lookup tables pass for COFF, allowing
it to be reenabled.
Paths
| Differential D102217
[COFF] Fix ARM and ARM64 REL32 relocations to be relative to the end of the relocation ClosedPublic Authored by mstorsjo on May 11 2021, 12:26 AM.
Details Summary This matches how they are defined on X86. This should fix the relative lookup tables pass for COFF, allowing
Diff Detail
Event TimelineHerald added subscribers: pengfei, hiraditya, kristof.beyls. · View Herald TranscriptMay 11 2021, 12:26 AM Comment Actions lgtm
This revision is now accepted and ready to land.May 11 2021, 11:03 AM
This revision was landed with ongoing or failed builds.May 11 2021, 11:53 PM Closed by commit rG382c505d9cfc: [COFF] Fix ARM and ARM64 REL32 relocations to be relative to the end of the… (authored by mstorsjo). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 344687 llvm/lib/MC/WinCOFFObjectWriter.cpp
llvm/test/MC/AArch64/coff-relocations.s
llvm/test/MC/ARM/coff-relocations.s
|
This is kind of the same thing. There's probably a refactoring here, but not without lots of surgery to the comments.