Page MenuHomePhabricator

richard.townsend.arm (Richard Townsend (Arm))
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2019, 2:06 PM (8 w, 6 d)

Recent Activity

May 3 2019

richard.townsend.arm added a comment to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.

Just completed testing... everything seems to be working correctly. So long as the all the tests pass, let's commit! :D

May 3 2019, 8:51 AM · Restricted Project

May 1 2019

richard.townsend.arm added a comment to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.

And with those modifications, everything seems to work correctly. I'd be fine with the LLVM portion landing at this stage, but one more rev and another test cycle for this patch would be ideal.

May 1 2019, 1:23 PM · Restricted Project

Apr 30 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 30 2019, 4:04 PM · Restricted Project
richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 30 2019, 2:54 PM · Restricted Project
richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 30 2019, 2:11 PM · Restricted Project

Apr 29 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 29 2019, 8:39 AM · Restricted Project
richard.townsend.arm added a comment to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.

Apologies, I meant to write "here's what Clang is trying to call" in the previous comment. It's clear from looking at MSVC's output that MSVC expects to return indirectly via X0, implying that _Smanip is not aggregate by MSVC's definition.

Apr 29 2019, 7:16 AM · Restricted Project
richard.townsend.arm added a comment to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.

The current diff (196894) seems to have the same std::setw issue as the previous one. Here's what it's trying to compile:

Apr 29 2019, 7:09 AM · Restricted Project

Apr 26 2019

richard.townsend.arm added a comment to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.

Confirmed just now that the current diff (196774) does work, but it'd be good to correct user-provided constructors and trivial destructors before this lands.

Apr 26 2019, 10:43 AM · Restricted Project

Apr 25 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 25 2019, 8:18 AM · Restricted Project
richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 25 2019, 5:39 AM · Restricted Project

Apr 23 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 23 2019, 9:29 AM · Restricted Project

Apr 18 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 18 2019, 10:43 AM · Restricted Project

Apr 17 2019

richard.townsend.arm added inline comments to D60349: [COFF, ARM64] Fix ABI implementation of struct returns.
Apr 17 2019, 3:45 PM · Restricted Project