This is an archive of the discontinued LLVM Phabricator instance.

[spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef
ClosedPublic

Authored by antiagainst on May 6 2021, 10:24 AM.

Diff Detail

Event Timeline

antiagainst created this revision.May 6 2021, 10:24 AM
antiagainst requested review of this revision.May 6 2021, 10:24 AM
rriddle accepted this revision.May 6 2021, 11:43 AM

Thanks Lei!

mlir/include/mlir/Dialect/SPIRV/Linking/ModuleCombiner.h
73

Can you just add an include for LLVM.h?

mlir/lib/Target/SPIRV/Deserialization/Deserialization.cpp
13–23
This revision is now accepted and ready to land.May 6 2021, 11:43 AM
antiagainst marked 2 inline comments as done.

Address comments

This revision was landed with ongoing or failed builds.May 6 2021, 2:20 PM
This revision was automatically updated to reflect the committed changes.