This is an archive of the discontinued LLVM Phabricator instance.

[lld] Add a feature for each lld variant when use_lld is called
ClosedPublic

Authored by jhenderson on May 6 2021, 7:49 AM.

Details

Summary

This allows tests to detect whether to run or not, dependent on which LLD version is required for the test.

Diff Detail

Event Timeline

jhenderson created this revision.May 6 2021, 7:49 AM
jhenderson requested review of this revision.May 6 2021, 7:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2021, 7:49 AM
Herald added a subscriber: aheejin. · View Herald Transcript
thopre added inline comments.May 6 2021, 8:39 AM
llvm/utils/lit/tests/Inputs/lld-features/lit.cfg
13–16

This seems to be leaking from https://reviews.llvm.org/D101995

jhenderson added inline comments.May 7 2021, 12:59 AM
llvm/utils/lit/tests/Inputs/lld-features/lit.cfg
13–16

Not entirely sure what you mean by "leaking" here. I'm making use of the environment variable to ensure there's a real file being pointed at so that the features are enabled. Strictly, it's not required as there's no check for existence of the file specified by the environment variable, but that might change in the future.

thopre accepted this revision.May 7 2021, 1:45 AM
thopre added inline comments.
llvm/utils/lit/tests/Inputs/lld-features/lit.cfg
13–16

My bad, I stupidly thought it was the same test as in the other patch and the rest of my thought process was even more broken. All good.

This revision is now accepted and ready to land.May 7 2021, 1:45 AM
jhenderson planned changes to this revision.May 17 2021, 2:06 AM

As D101995 has been abandoned, I'll need to update the testing for this patch.

Update test to not depend on D101995.

This revision is now accepted and ready to land.May 17 2021, 2:58 AM
jhenderson requested review of this revision.May 17 2021, 2:58 AM

@thopre, could you confirm you're happy with the latest version of the test, please?

thopre accepted this revision.May 17 2021, 3:03 AM

LGTM

This revision is now accepted and ready to land.May 17 2021, 3:03 AM
jhenderson added inline comments.May 17 2021, 7:45 AM
llvm/utils/lit/tests/Inputs/lld-features/lit.cfg
18

Depending on whether I land this patch or D102630 first, this line somewhere will need to change to use_lld(use_installed=True).

This revision was landed with ongoing or failed builds.May 18 2021, 2:52 AM
This revision was automatically updated to reflect the committed changes.