This is an archive of the discontinued LLVM Phabricator instance.

Differential D101863

[DebugInfo][test][MIPS] Use mtriple in tests
ClosedPublic

Authored by jsji on May 4 2021, 2:40 PM.

Details

Reviewers
aprantl
vkalintiris
atanasyan
phosek
Commits
rGf6ef409406d7: [DebugInfo][test][MIPS] Use mtriple in tests
Summary

Mips tests are using -march in RUN lines,
this will fail on AIX OS , when we get the mips-ibm-aix triple.

This is caused/exposed recently due to https://reviews.llvm.org/D101194 changed the default getMultiarchTriple in toolchain.

Update the tests to use -mtriple instead to avoid unintended failures.

Diff Detail

Event Timeline

jsji created this revision.May 4 2021, 2:40 PM
Herald added subscribers: jrtc27, arichardson, sdardis. · View Herald TranscriptMay 4 2021, 2:40 PM
jsji requested review of this revision.May 4 2021, 2:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 2:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
jsji edited the summary of this revision. (Show Details)May 4 2021, 3:08 PM
Harbormaster completed remote builds in B102617: Diff 342874.May 4 2021, 3:18 PM
jsji added a reviewer: phosek.May 4 2021, 3:21 PM
atanasyan accepted this revision.May 5 2021, 1:32 AM

LGTM

This revision is now accepted and ready to land.May 5 2021, 1:32 AM
Closed by commit rGf6ef409406d7: [DebugInfo][test][MIPS] Use mtriple in tests (authored by jsji). · Explain WhyMay 5 2021, 6:51 AM
This revision was automatically updated to reflect the committed changes.
jsji added a commit: rGf6ef409406d7: [DebugInfo][test][MIPS] Use mtriple in tests.

Revision Contents

PathSize
llvm/
test/
DebugInfo/
Mips/
2 lines
2 lines
8 lines

Diff 343030

llvm/test/DebugInfo/Mips/dsr-fixed-objects.ll

; RUN: llc -march=mips -mcpu=mips32r2 -O1 -filetype=obj -relocation-model=pic <%s | \ ; RUN: llc -mtriple=mips -mcpu=mips32r2 -O1 -filetype=obj -relocation-model=pic <%s | \
; RUN: llvm-dwarfdump -v -all - | FileCheck %s ; RUN: llvm-dwarfdump -v -all - | FileCheck %s
; void foo(int *); ; void foo(int *);
; ;
; int f0(int a, int b, int c, int d, int e) { ; int f0(int a, int b, int c, int d, int e) {
; int x = a + b + c + d + e; ; int x = a + b + c + d + e;
; foo(&x); ; foo(&x);
; return x; ; return x;
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines

llvm/test/DebugInfo/Mips/dsr-non-fixed-objects.ll

; RUN: llc -march=mips -mcpu=mips32r2 -O0 -filetype=obj -fast-isel=0 <%s | \ ; RUN: llc -mtriple=mips -mcpu=mips32r2 -O0 -filetype=obj -fast-isel=0 <%s | \
; RUN: llvm-dwarfdump -v -all - | FileCheck %s ; RUN: llvm-dwarfdump -v -all - | FileCheck %s
declare void @llvm.dbg.declare(metadata, metadata, metadata) declare void @llvm.dbg.declare(metadata, metadata, metadata)
declare void @foo(i32*) declare void @foo(i32*)
; void foo(int *); ; void foo(int *);
; ;
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

llvm/test/DebugInfo/Mips/dwarfdump-tls.ll

; RUN: llc -O0 -march=mips -mcpu=mips32r2 -filetype=obj \ ; RUN: llc -O0 -mtriple=mips -mcpu=mips32r2 -filetype=obj \
; RUN: -split-dwarf-file=foo.dwo -o=%t-32.o < %s ; RUN: -split-dwarf-file=foo.dwo -o=%t-32.o < %s
; RUN: llvm-dwarfdump %t-32.o 2>&1 | FileCheck %s ; RUN: llvm-dwarfdump %t-32.o 2>&1 | FileCheck %s
; RUN: llc -O0 -march=mips64 -mcpu=mips64r2 -filetype=obj \ ; RUN: llc -O0 -mtriple=mips64 -mcpu=mips64r2 -filetype=obj \
; RUN: -split-dwarf-file=foo.dwo -o=%t-64.o < %s ; RUN: -split-dwarf-file=foo.dwo -o=%t-64.o < %s
; RUN: llvm-dwarfdump %t-64.o 2>&1 | FileCheck %s ; RUN: llvm-dwarfdump %t-64.o 2>&1 | FileCheck %s
; RUN: llc -O0 -march=mips -mcpu=mips32r2 -filetype=asm \ ; RUN: llc -O0 -mtriple=mips -mcpu=mips32r2 -filetype=asm \
; RUN: -split-dwarf-file=foo.dwo < %s | FileCheck -check-prefix=ASM32 %s ; RUN: -split-dwarf-file=foo.dwo < %s | FileCheck -check-prefix=ASM32 %s
; RUN: llc -O0 -march=mips64 -mcpu=mips64r2 -filetype=asm \ ; RUN: llc -O0 -mtriple=mips64 -mcpu=mips64r2 -filetype=asm \
; RUN: -split-dwarf-file=foo.dwo < %s | FileCheck -check-prefix=ASM64 %s ; RUN: -split-dwarf-file=foo.dwo < %s | FileCheck -check-prefix=ASM64 %s
@x = thread_local global i32 5, align 4, !dbg !0 @x = thread_local global i32 5, align 4, !dbg !0
; CHECK-NOT: error: failed to compute relocation: R_MIPS_TLS_DTPREL ; CHECK-NOT: error: failed to compute relocation: R_MIPS_TLS_DTPREL
; CHECK: DW_AT_name ("x") ; CHECK: DW_AT_name ("x")
; CHECK-NEXT: DW_AT_type (0x00000025 "int") ; CHECK-NEXT: DW_AT_type (0x00000025 "int")
Show All 25 Lines