Page MenuHomePhabricator

[MLIR][Linalg] Lower `linalg.tiled_loop` in a separate pass
ClosedPublic

Authored by frgossen on May 3 2021, 10:31 AM.

Details

Summary

Add dedicated pass convert-linalg-tiled-loops to lower linalg.tiled_loops.

Diff Detail

Event Timeline

frgossen created this revision.May 3 2021, 10:31 AM
frgossen requested review of this revision.May 3 2021, 10:31 AM
pifon2a accepted this revision.May 3 2021, 10:43 AM
pifon2a added inline comments.
mlir/include/mlir/Dialect/Linalg/Passes.td
61

nit: convert-linalg-tiled-loops-to-scf?

102–109

why was it moved?

mlir/lib/Dialect/Linalg/Transforms/Loops.cpp
683

createConvertLinalgTiledLoopsToScfPass

mlir/test/Dialect/Linalg/tiled-loops.mlir
1

there might be direct conversions to GPU, Async, etc from TiledLoopOps. Let's call it convert-linalg-tiled-loops-to-scf.

This revision is now accepted and ready to land.May 3 2021, 10:43 AM
frgossen updated this revision to Diff 342490.May 3 2021, 11:58 AM

Rename pass

frgossen marked 4 inline comments as done.May 3 2021, 12:00 PM

Thanks!

mlir/include/mlir/Dialect/Linalg/Passes.td
102–109

Moved LinalgLowerToParallelLoops right after LinalgLowerToLoops as they belong together.

This revision was landed with ongoing or failed builds.May 3 2021, 12:02 PM
This revision was automatically updated to reflect the committed changes.
frgossen marked an inline comment as done.