Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I think the requirements are better documented by using the actual paths, e.g. MicroBenchmarks/XRay/ in this case.
Add @Meinersbur for some ideas how per-project requirements should be organized.
Comment Actions
With XRay basically unmaintained, I would love to see the compiler-rt requirement to go away. At least, its availability could be autodetected. That is, if unavailable, one could see that the X-Ray tests are disabled in the cmake output.
Until then I think the note could be helpful.
llvm/docs/TestSuiteGuide.md | ||
---|---|---|
47–48 | It might be preferable to add it to LLVM_ENABLE_RUNTIMES instead. |
Comment Actions
LGTM
We don't have a requirements list in the docs yet. I think it is going beyond the scope of this patch to create one now.
It might be preferable to add it to LLVM_ENABLE_RUNTIMES instead.