This is an archive of the discontinued LLVM Phabricator instance.

[docs] Add the compiler-rt requirement to the test suite doc
ClosedPublic

Authored by mtrofin on Apr 28 2021, 9:11 AM.

Diff Detail

Event Timeline

mtrofin created this revision.Apr 28 2021, 9:11 AM
mtrofin requested review of this revision.Apr 28 2021, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2021, 9:11 AM

I think the requirements are better documented by using the actual paths, e.g. MicroBenchmarks/XRay/ in this case.
Add @Meinersbur for some ideas how per-project requirements should be organized.

MaskRay resigned from this revision.Apr 28 2021, 3:36 PM

With XRay basically unmaintained, I would love to see the compiler-rt requirement to go away. At least, its availability could be autodetected. That is, if unavailable, one could see that the X-Ray tests are disabled in the cmake output.

Until then I think the note could be helpful.

llvm/docs/TestSuiteGuide.md
47–48

It might be preferable to add it to LLVM_ENABLE_RUNTIMES instead.

Patch to disable X-Ray tests if compiled without compiler-rt: D106415

mtrofin updated this revision to Diff 360475.Jul 21 2021, 8:42 AM
mtrofin marked an inline comment as done.

LLVM_ENABLE_RUNTIMES instead of _PROJECTS

mtrofin updated this revision to Diff 360478.Jul 21 2021, 8:45 AM

updated note

llvm/docs/TestSuiteGuide.md
47–48

done. also reworded the note in light of D106415.

Meinersbur accepted this revision.Jul 21 2021, 12:08 PM
Meinersbur added a subscriber: MaskRay.

LGTM

Add @Meinersbur for some ideas how per-project requirements should be organized.

We don't have a requirements list in the docs yet. I think it is going beyond the scope of this patch to create one now.

This revision is now accepted and ready to land.Jul 21 2021, 12:08 PM
This revision was landed with ongoing or failed builds.Jul 22 2021, 4:04 PM
This revision was automatically updated to reflect the committed changes.