So far, only a conversion for complex::AbsOp is done, but more will be added.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Conversion/Passes.td | ||
---|---|---|
106 | Thanks for the suggestion :) |
The conversion of AbsOp in this patch does not account for underflows or overflows. Since it does not use higher precisions for computing the intermediate results, it might not be precise as well. We are hitting an underflow issue in Flang due to using this conversion. https://github.com/llvm/llvm-project/issues/62011
What are the plans for this pass? Would you accept fixes to improve precision or is the assumption that we should only use this pass where preciseness is not important?
Thanks in advance.
is it a ModuleOp pass because you want to convert func args of ComplexType? If not, then would FunctionPass be enough?