Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/RISCV/RISCVInstrInfo.td | ||
---|---|---|
1306 | Misleading name given the hasOneUse |
llvm/lib/Target/RISCV/RISCVInstrInfo.td | ||
---|---|---|
1306 | I think the more common way to do this is to have to have an "add_oneuse" PatFrag that call N->hasOneUse() See and_su, xor_su, fmul_su in ARMInstrInfo.td or and_su, srl_su, trunc_su in X86/X86InstrInfo.td. _su in all of those stands for "single use", but "_oneuse" is more readable |
llvm/lib/Target/RISCV/RISCVInstrInfo.td | ||
---|---|---|
348 | I'm confused why this works. The types on RV64 are all i64. I don't think tablegen should be accepting an i32. Does the pattern work if you use AddiPair? |
llvm/lib/Target/RISCV/RISCVInstrInfo.td | ||
---|---|---|
348 | Yes. It works with only AddiPair, and I have removed the Addi32Pair. |
I'm confused why this works. The types on RV64 are all i64. I don't think tablegen should be accepting an i32. Does the pattern work if you use AddiPair?