This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][AIX] Set target debugger-tune default to dbx
ClosedPublic

Authored by jsji on Apr 23 2021, 1:13 PM.

Details

Summary

https://reviews.llvm.org/D99400 set clang DefaultDebuggerTuning for AIX
to dbx. However, we still need to update the target default so that llc
and other tools will get the same default debuggertuning, and avoid
passing extra options in LTO.

Diff Detail

Event Timeline

jsji created this revision.Apr 23 2021, 1:13 PM
jsji requested review of this revision.Apr 23 2021, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2021, 1:13 PM
dblaikie added inline comments.Apr 23 2021, 1:22 PM
llvm/test/DebugInfo/PowerPC/debugger-tune.ll
4

Maybe "We use the use of DW_FORM_string (rather than DW_FORM_strp) to distinguish debugger tuning"

15–16

Rather than "not" maybe implicit-check-not and an active check for the positive case (otherwise if we used some futuristic alternative string encoding (like DWARFv5 strx encodings if we change to DWARFv5 by default) this test would still pass accidentally)

jsji added inline comments.Apr 23 2021, 2:49 PM
llvm/test/DebugInfo/PowerPC/debugger-tune.ll
15–16

Good suggestion. Thanks!

jsji updated this revision to Diff 340171.Apr 23 2021, 2:50 PM

Address review comments.

jsji marked 2 inline comments as done.Apr 23 2021, 2:50 PM
dblaikie accepted this revision.Apr 23 2021, 4:06 PM

Looks good, thanks!

This revision is now accepted and ready to land.Apr 23 2021, 4:06 PM
shchenz accepted this revision.Apr 24 2021, 5:45 PM

This will save the option setting for tuning debugger for components involving llc (for example, LTO) as described in the description.
LGTM too. Thanks for doing this.

This revision was landed with ongoing or failed builds.Apr 25 2021, 6:39 PM
This revision was automatically updated to reflect the committed changes.