Based on D101079.
Details
Details
- Reviewers
ldionne cjdb • Quuxplusone EricWF - Group Reviewers
Restricted Project - Commits
- rG6f1b10df916f: [libcxx][ranges] Add ranges::ssize CPO.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/include/__ranges/size.h | ||
---|---|---|
103–104 | invocable<__size::__fn, _Tp>? |
Comment Actions
LGTM with changes applied.
libcxx/include/__ranges/size.h | ||
---|---|---|
108 | Here instead I would just write require (_Tp&& __t) { ranges::size(__t); } and get rid of __can_invoke_size. Closer to the spec and simpler IMO. | |
libcxx/test/std/ranges/range.access/range.prim/size.pass.cpp | ||
45 | Can we move the ssize tests to their own file? |
Comment Actions
LGTM (please update synopsis).
By the way, no need to re-run CI for such minor changes. Just make the change and ship it, no need to add any more latency to the loop.
invocable<__size::__fn, _Tp>?