Page MenuHomePhabricator

[RISCV] Implement the vneg.v builtin.
ClosedPublic

Authored by HsiangKai on Tue, Apr 20, 12:36 AM.

Diff Detail

Event Timeline

HsiangKai created this revision.Tue, Apr 20, 12:36 AM
HsiangKai requested review of this revision.Tue, Apr 20, 12:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Apr 20, 12:36 AM
frasercrmck added inline comments.Wed, Apr 21, 1:54 AM
clang/utils/TableGen/RISCVVEmitter.cpp
1053

Does this only affect vneg or are there other changes to the tablegenned code as a consequence?

khchen added inline comments.Wed, Apr 21, 3:03 AM
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c
4

nit: The integer intrinsic functions do not need the -target-feature +f, +d and +experimental-zfh.

craig.topper added inline comments.Wed, Apr 21, 9:03 AM
clang/utils/TableGen/RISCVVEmitter.cpp
1053

Is this needed for fneg? When we implemented this change downstream, I thought it was for compares due to how vmsge.vx was handled.

HsiangKai updated this revision to Diff 339452.Wed, Apr 21, 7:56 PM

Address comments.

HsiangKai marked 3 inline comments as done.Wed, Apr 21, 7:57 PM
HsiangKai added inline comments.
clang/utils/TableGen/RISCVVEmitter.cpp
1053

Thanks for pointing it out. I reverted it.

This revision is now accepted and ready to land.Thu, Apr 22, 4:45 PM
This revision was landed with ongoing or failed builds.Thu, Apr 22, 8:41 PM
This revision was automatically updated to reflect the committed changes.
HsiangKai marked an inline comment as done.