Page MenuHomePhabricator

[MLIR] Fix `isValidIndex`

Authored by frgossen on Apr 16 2021, 3:30 AM.


Diff Detail

Event Timeline

frgossen created this revision.Apr 16 2021, 3:30 AM
frgossen requested review of this revision.Apr 16 2021, 3:30 AM
herhut accepted this revision.Apr 16 2021, 5:18 AM

Thanks. I can see this to be useful as we use -1 for unknown quite often.

This revision is now accepted and ready to land.Apr 16 2021, 5:18 AM

I ran into this where an index was constant-folded to -1 for an unreachable branch and the canonicalization for an extract op crashed subsequently.

This revision was automatically updated to reflect the committed changes.