This is an archive of the discontinued LLVM Phabricator instance.

[clangd][test] Fix build error of FeatureModulesTests
ClosedPublic

Authored by TaoPan on Apr 15 2021, 6:37 PM.

Details

Summary

clang-tools-extra/clangd/unittests/FeatureModulesTests.cpp:33:58: error:
could not convert ‘(const char*)""’ from ‘const char*’ to
llvm::StringLiteral’

llvm::StringLiteral kind() const override { return ""; };

Diff Detail

Event Timeline

TaoPan created this revision.Apr 15 2021, 6:37 PM
TaoPan requested review of this revision.Apr 15 2021, 6:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2021, 6:37 PM

Hi sammccall,

FeatureModulesTests.cpp was added by D98498, could you please have a review?

kadircet accepted this revision.Apr 16 2021, 1:25 AM

thanks, lgtm! which compiler is this btw?

This revision is now accepted and ready to land.Apr 16 2021, 1:25 AM

thanks, lgtm! which compiler is this btw?

Thanks! I used gcc version 5.4.0 on Ubuntu 16.04