[AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

[sdesmalen]

Summary

This fixes a subtle issue where:

svprf(pg, ptr, SV_ALL /*is sv_pattern instead of sv_prfop*/)

would be quietly accepted. With this change, the function declaration
guards that the third parameter is a enum sv_prfop. Previously svprf
would map directly to __builtin_sve_svprfb, which accepts the enum
operand as a signed integer and only checks that the incoming range is
valid, meaning that SV_ALL would be discarded as being outside the valid
immediate range, but would have allowed SV_VL1 without issuing a warning
(C) or error (C++).

[c-rhodes]

LGTM

clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfb.c

 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
 
 #include <arm_sve.h>
 
 void test_svprfb(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfb(pg, base, 14);
 }
 
 void test_svprfb_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfb(pg, base, -1);
 }
 
 void test_svprfb_vnum(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfb_vnum(pg, base, 0, 14);
 }
 
 void test_svprfb_vnum_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfb_vnum(pg, base, 0, -1);
 }
+
+void test_svprfb_svpattern(svbool_t pg, const void *base)
+{
+  // expected-warning@+1 {{implicit conversion from enumeration type 'enum svpattern' to different enumeration type 'enum svprfop'}}
+  return svprfb(pg, base, SV_VL1);
+}

clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfd.c

 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
 
 #include <arm_sve.h>
 
 void test_svprfd(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfd(pg, base, 14);
 }
 
 void test_svprfd_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfd(pg, base, -1);
 }
 
 void test_svprfd_vnum(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfd_vnum(pg, base, 0, 14);
 }
 
 void test_svprfd_vnum_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfd_vnum(pg, base, 0, -1);
 }

clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfh.c

 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
 
 #include <arm_sve.h>
 
 void test_svprfh(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfh(pg, base, 14);
 }
 
 void test_svprfh_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfh(pg, base, -1);
 }
 
 void test_svprfh_vnum(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfh_vnum(pg, base, 0, 14);
 }
 
 void test_svprfh_vnum_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfh_vnum(pg, base, 0, -1);
 }

clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfw.c

 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
 
 #include <arm_sve.h>
 
 void test_svprfw(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfw(pg, base, 14);
 }
 
 void test_svprfw_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfw(pg, base, -1);
 }
 
 void test_svprfw_vnum(svbool_t pg, const void *base)
 {
   // expected-error@+1 {{argument value 14 is outside the valid range [0, 13]}}
   return svprfw_vnum(pg, base, 0, 14);
 }
 
 void test_svprfw_vnum_1(svbool_t pg, const void *base)
 {
-  // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}}
+  // expected-error-re@+1 {{argument value {{.*}} is outside the valid range [0, 13]}}
   return svprfw_vnum(pg, base, 0, -1);
 }

clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_qdecb.c

uint64_t test_svqdecb_pat_n_u64(uint64_t op)
   return SVE_ACLE_FUNC(svqdecb_pat,_n_u64,,)(op, SV_VL6, 0);
 }
 
 uint64_t test_svqdecb_pat_n_u64_1(uint64_t op)
 {
   // expected-error-re@+1 {{argument value {{[0-9]+}} is outside the valid range [1, 16]}}
   return SVE_ACLE_FUNC(svqdecb_pat,_n_u64,,)(op, SV_VL7, 17);
 }
+
+uint64_t test_svqdecb_svprfop(uint64_t op)
+{
+  // expected-warning@+1 {{implicit conversion from enumeration type 'enum svprfop' to different enumeration type 'enum svpattern'}}
+  return SVE_ACLE_FUNC(svqdecb_pat,_n_u64,,)(op, SV_PLDL1KEEP, 1);
+}

clang/utils/TableGen/SveEmitter.cpp

std::string Intrinsic::mangleName(ClassKind LocalCK) const {
   }
 
   // Replace all {d} like expressions with e.g. 'u32'
   return replaceTemplatedArgs(S, getBaseTypeSpec(), getProto()) +
          getMergeSuffix();
 }
 
 void Intrinsic::emitIntrinsic(raw_ostream &OS) const {
-  // Use the preprocessor to 
-  if (getClassKind() != ClassG || getProto().size() <= 1) {
-    OS << "#define " << mangleName(getClassKind())
-       << "(...) __builtin_sve_" << mangleName(ClassS)
-       << "(__VA_ARGS__)\n";
-  } else {
-    std::string FullName = mangleName(ClassS);
-    std::string ProtoName = mangleName(ClassG);
+  bool IsOverloaded = getClassKind() == ClassG && getProto().size() > 1;
+
+  std::string ProtoName = mangleName(getClassKind());
 
-    OS << "__aio __attribute__((__clang_arm_builtin_alias("
-       << "__builtin_sve_" << FullName << ")))\n";
+  OS << (IsOverloaded ? "__aio " : "__ai ")
+     << "__attribute__((__clang_arm_builtin_alias("
 
-    OS << getTypes()[0].str() << " " << ProtoName << "(";
-    for (unsigned I = 0; I < getTypes().size() - 1; ++I) {
-      if (I != 0)
-        OS << ", ";
-      OS << getTypes()[I + 1].str();
-    }
-    OS << ");\n";
-  }
-}
 
 //===----------------------------------------------------------------------===//
 // SVEEmitter implementation
 //===----------------------------------------------------------------------===//
 uint64_t SVEEmitter::encodeTypeFlags(const SVEType &T) {
   if (T.isFloat()) {
     switch (T.getElementSizeInBits()) {
     case 16:
void SVEEmitter::createHeader(raw_ostream &OS) {
   OS << "  SV_PSTL1STRM = 9,\n";
   OS << "  SV_PSTL2KEEP = 10,\n";
   OS << "  SV_PSTL2STRM = 11,\n";
   OS << "  SV_PSTL3KEEP = 12,\n";
   OS << "  SV_PSTL3STRM = 13\n";
   OS << "};\n\n";
 
   OS << "/* Function attributes */\n";
+  OS << "#define __ai static __inline__ __attribute__((__always_inline__, "
+        "__nodebug__))\n\n";
   OS << "#define __aio static __inline__ __attribute__((__always_inline__, "
         "__nodebug__, __overloadable__))\n\n";
 
   // Add reinterpret functions.
   for (auto ShortForm : { false, true } )
     for (const ReinterpretTypeInfo &From : Reinterprets)
       for (const ReinterpretTypeInfo &To : Reinterprets) {
         const bool IsBFloat = StringRef(From.Suffix).equals("bf16") ||