Fix static code analysis concerns with uninitialized variables

[Manna]

Summary

RISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with uninitialized variables warnings - NFCI

[RKSimon]

LGTM

Out of interest, which analyzer is reporting this? detectFPCCEligibleStruct always clears those values at the start of the method so its annoying if clang can't peek in to realise that.

[Manna]

In D100172#2679375, @RKSimon wrote:

LGTM

Out of interest, which analyzer is reporting this? detectFPCCEligibleStruct always clears those values at the start of the method so its annoying if clang can't peek in to realise that.

Thank you, Simon for the quick response and the acceptance. Klocwork is reporting this. Would it be possible to commit the patch?

Thanks,
Soumi Manna

[RKSimon]

In D100172#2679392, @Manna wrote:

In D100172#2679375, @RKSimon wrote:

LGTM

Out of interest, which analyzer is reporting this? detectFPCCEligibleStruct always clears those values at the start of the method so its annoying if clang can't peek in to realise that.

Thank you, Simon for the quick response and the acceptance. Klocwork is reporting this. Would it be possible to commit the patch?

Sure, whats your email address please?

[Manna]

In D100172#2679423, @RKSimon wrote:

In D100172#2679392, @Manna wrote:

In D100172#2679375, @RKSimon wrote:

LGTM

Out of interest, which analyzer is reporting this? detectFPCCEligibleStruct always clears those values at the start of the method so its annoying if clang can't peek in to realise that.

Thank you, Simon for the quick response and the acceptance. Klocwork is reporting this. Would it be possible to commit the patch?

Sure, whats your email address please?

Thank you, Simon. I greatly appreciate it. Email address: [e-mail]

clang/lib/CodeGen/TargetInfo.cpp

if (IsFixed && Ty->isComplexType() && FLen && ArgFPRsLeft >= 2) {
     }
   }
 
   if (IsFixed && FLen && Ty->isStructureOrClassType()) {
     llvm::Type *Field1Ty = nullptr;
     llvm::Type *Field2Ty = nullptr;
     CharUnits Field1Off = CharUnits::Zero();
     CharUnits Field2Off = CharUnits::Zero();
-    int NeededArgGPRs;
-    int NeededArgFPRs;
+    int NeededArgGPRs = 0;
+    int NeededArgFPRs = 0;
     bool IsCandidate =
         detectFPCCEligibleStruct(Ty, Field1Ty, Field1Off, Field2Ty, Field2Off,
                                  NeededArgGPRs, NeededArgFPRs);
     if (IsCandidate && NeededArgGPRs <= ArgGPRsLeft &&
         NeededArgFPRs <= ArgFPRsLeft) {
       ArgGPRsLeft -= NeededArgGPRs;
       ArgFPRsLeft -= NeededArgFPRs;
       return coerceAndExpandFPCCEligibleStruct(Field1Ty, Field1Off, Field2Ty,