This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in lib/Basic
AbandonedPublic

Authored by LegalizeAdulthood on May 25 2015, 12:52 PM.

Download Raw Diff

Details

Reviewers

chandlerc
akyrtzi
krememek
craig.topper
• rafael
bkramer
doug.gregor

Summary

Use clang-tidy to simplify boolean conditional return statements

Diff Detail

Event Timeline

LegalizeAdulthood updated this revision to Diff 26478.May 25 2015, 12:52 PM

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in lib/Basic.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added reviewers: doug.gregor, rsmith, rjmccall, akyrtzi, krememek, majnemer.

LegalizeAdulthood edited reviewers, added: • ddunbar, • rafael, bkramer, craig.topper, chandlerc; removed: majnemer, rjmccall, rsmith.

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

diff -U9999

• ddunbar resigned from this revision.May 25 2015, 1:26 PM

• ddunbar removed a reviewer: • ddunbar.

LGTM

This revision is now accepted and ready to land.May 26 2015, 6:58 AM

Update to latest.
I do not have commit access.

The patch doesn't apply cleanly. You need to rebase it again.

LegalizeAdulthood abandoned this revision.Feb 19 2016, 9:22 AM

Revision Contents

Path

Size

lib/

Basic/

Targets.cpp

6 lines

Diff 38318

lib/Basic/Targets.cpp

Show First 20 Lines • Show All 2,698 Lines • ▼ Show 20 Lines	bool X86TargetInfo::initFeatureMap(
if (!TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec))		if (!TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec))
return false;		return false;

// Can't do this earlier because we need to be able to explicitly enable		// Can't do this earlier because we need to be able to explicitly enable
// or disable these features and the things that they depend upon.		// or disable these features and the things that they depend upon.

// Enable popcnt if sse4.2 is enabled and popcnt is not explicitly disabled.		// Enable popcnt if sse4.2 is enabled and popcnt is not explicitly disabled.
auto I = Features.find("sse4.2");		auto I = Features.find("sse4.2");
if (I != Features.end() && I->getValue() == true &&		if (I != Features.end() && I->getValue() &&
std::find(FeaturesVec.begin(), FeaturesVec.end(), "-popcnt") ==		std::find(FeaturesVec.begin(), FeaturesVec.end(), "-popcnt") ==
FeaturesVec.end())		FeaturesVec.end())
Features["popcnt"] = true;		Features["popcnt"] = true;

// Enable prfchw if 3DNow! is enabled and prfchw is not explicitly disabled.		// Enable prfchw if 3DNow! is enabled and prfchw is not explicitly disabled.
I = Features.find("3dnow");		I = Features.find("3dnow");
if (I != Features.end() && I->getValue() == true &&		if (I != Features.end() && I->getValue() &&
std::find(FeaturesVec.begin(), FeaturesVec.end(), "-prfchw") ==		std::find(FeaturesVec.begin(), FeaturesVec.end(), "-prfchw") ==
FeaturesVec.end())		FeaturesVec.end())
Features["prfchw"] = true;		Features["prfchw"] = true;

// Additionally, if SSE is enabled and mmx is not explicitly disabled,		// Additionally, if SSE is enabled and mmx is not explicitly disabled,
// then enable MMX.		// then enable MMX.
I = Features.find("sse");		I = Features.find("sse");
if (I != Features.end() && I->getValue() == true &&		if (I != Features.end() && I->getValue() &&
std::find(FeaturesVec.begin(), FeaturesVec.end(), "-mmx") ==		std::find(FeaturesVec.begin(), FeaturesVec.end(), "-mmx") ==
FeaturesVec.end())		FeaturesVec.end())
Features["mmx"] = true;		Features["mmx"] = true;

return true;		return true;
}		}

void X86TargetInfo::setSSELevel(llvm::StringMap<bool> &Features,		void X86TargetInfo::setSSELevel(llvm::StringMap<bool> &Features,
▲ Show 20 Lines • Show All 4,990 Lines • Show Last 20 Lines