Refactor: Simplify boolean conditional return statements in lib/Basic

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements

[LegalizeAdulthood]

diff -U9999

[• rafael]

LGTM

[LegalizeAdulthood]

Update to latest.
I do not have commit access.

[alexfh]

The patch doesn't apply cleanly. You need to rebase it again.

lib/Basic/DiagnosticIDs.cpp

bool DiagnosticIDs::isUnrecoverable(unsigned DiagID) const {
   if (getBuiltinDiagClass(DiagID) < CLASS_ERROR)
     return false;
 
   if (DiagID == diag::err_unavailable ||
       DiagID == diag::err_unavailable_message)
     return false;
 
   // Currently we consider all ARC errors as recoverable.
-  if (isARCDiagnostic(DiagID))
-    return false;
-
-  return true;
+  return !isARCDiagnostic(DiagID);
 }
 
 bool DiagnosticIDs::isARCDiagnostic(unsigned DiagID) {
   unsigned cat = getCategoryNumberForDiag(DiagID);
   return DiagnosticIDs::getCategoryNameFromID(cat).startswith("ARC ");
 }

lib/Basic/VirtualFileSystem.cpp

for (yaml::MappingNode::iterator I = Top->begin(), E = Top->end(); I != E;
       } else {
         llvm_unreachable("key missing from Keys");
       }
     }
 
     if (Stream.failed())
       return false;
 
-    if (!checkMissingKeys(Top, Keys))
-      return false;
-    return true;
+    return checkMissingKeys(Top, Keys);
   }
 };
 } // end of anonymous namespace
 
 Entry::~Entry() {}
 DirectoryEntry::~DirectoryEntry() { llvm::DeleteContainerPointers(Contents); }
 
 VFSFromYAML::~VFSFromYAML() { llvm::DeleteContainerPointers(Roots); }