Page MenuHomePhabricator

[MLIR][Shape] Add convenience builder for `shape.assuming_all`
ClosedPublic

Authored by frgossen on Apr 8 2021, 6:41 AM.

Diff Detail

Event Timeline

frgossen created this revision.Apr 8 2021, 6:41 AM
frgossen requested review of this revision.Apr 8 2021, 6:41 AM
bkramer accepted this revision.Apr 8 2021, 10:10 AM
bkramer added inline comments.
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
751

Maybe add a comment that we can't generate it automatically because the op has variadic arguments.

This is a bug in our tblgen emitter, but I don't know what it takes to fix it.

frgossen updated this revision to Diff 336372.Apr 9 2021, 3:13 AM
frgossen marked an inline comment as done.

Address comment

frgossen added inline comments.Apr 9 2021, 3:16 AM
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
751

Shortly looked into this and the case (which is explicitly skipped).
There is a TODO for generalization though.
Will try to generalize this if it's quick enough.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2021, 3:18 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.