Page MenuHomePhabricator

[libcxx] adds `std::indirectly_writable` to <iterator>
AbandonedPublic

Authored by cjdb on Apr 7 2021, 5:07 PM.

Details

Reviewers
ldionne
EricWF
zoecarver
Mordante
curdeius
Quuxplusone
Group Reviewers
Restricted Project
Summary

Implements parts of:

  • P0896R4 The One Ranges Proposal`

Depends on D100073

Diff Detail

Unit TestsFailed

TimeTest
3,200 mslibcxx CI No locale > libc++.std/iterators/iterator_requirements/iterator_concepts/iterator_concept_readable::indirectly_readable.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.readable/indirectly_readable.compile.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/include/c++/v1 -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/projects/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.readable/Output/indirectly_readable.compile.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -Wno-macro-redefined -D_LIBCPP_HAS_NO_LOCALIZATION -fsyntax-only
2,860 mslibcxx CI No locale > libc++.std/iterators/iterator_requirements/iterator_concepts/iterator_concept_writable::indirectly_writable.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.writable/indirectly_writable.compile.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/include/c++/v1 -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/a12ddfe637b4-1/llvm-project/libcxx-ci/build/generic-no-localization/projects/libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.writable/Output/indirectly_writable.compile.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -Wno-macro-redefined -D_LIBCPP_HAS_NO_LOCALIZATION -fsyntax-only

Event Timeline

cjdb requested review of this revision.Apr 7 2021, 5:07 PM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2021, 5:07 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 336699.Apr 11 2021, 2:39 PM

updates synopsis, rebases to activate CI

zoecarver accepted this revision as: zoecarver.Apr 14 2021, 3:11 PM

LGTM. Thanks.

libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.writable/indirectly_writable.compile.pass.cpp
220

Only one template param.

cjdb updated this revision to Diff 337809.Apr 15 2021, 9:54 AM

rebases to activate CI

cjdb updated this revision to Diff 338415.Apr 18 2021, 7:31 PM

rebases to activate CI

cjdb abandoned this revision.Apr 20 2021, 4:14 PM

D100073 absorbed this patch.