[libcxx] adds `std::indirectly_writable` to <iterator>

[cjdb]

Summary

Implements parts of:

• P0896R4 The One Ranges Proposal`

Depends on D100073

[cjdb]

updates synopsis, rebases to activate CI

[zoecarver]

LGTM. Thanks.

libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.writable/indirectly_writable.compile.pass.cpp

221

Only one template param.

[cjdb]

rebases to activate CI

[cjdb]

rebases to activate CI

[cjdb]

D100073 absorbed this patch.

libcxx/include/iterator

 using iter_rvalue_reference_t
   = decltype(ranges::iter_move(declval<T&>()));
 
 // [iterator.concepts], iterator concepts
 // [iterator.concept.readable], concept indirectly_­readable
 template<class In>
   concept indirectly_readable = see below;                // since C++20
 
+// [iterator.concept.writable], concept indirectly_­writable
+template<class Out, class T>
+  concept indirectly_writable = see below;                // since C++20
+
 template<class Category, class T, class Distance = ptrdiff_t,
          class Pointer = T*, class Reference = T&>
 struct iterator
 {
     typedef T         value_type;
     typedef Distance  difference_type;
     typedef Pointer   pointer;
     typedef Reference reference;
concept __indirectly_readable_impl =
   } &&
   common_reference_with<iter_reference_t<_In>&&, iter_value_t<_In>&> &&
   common_reference_with<iter_reference_t<_In>&&, iter_rvalue_reference_t<_In>&&> &&
   common_reference_with<iter_rvalue_reference_t<_In>&&, const iter_value_t<_In>&>;
 
 template<class _In>
 concept indirectly_readable = __indirectly_readable_impl<remove_cvref_t<_In>>;
 
+// [iterator.concept.writable]
+template<class _Out, class _Tp>
+concept indirectly_writable =
+  requires(_Out&& __o, _Tp&& __t) {
+    *__o = _VSTD::forward<_Tp>(__t);                        // not required to be equality-preserving
+    *_VSTD::forward<_Out>(__o) = _VSTD::forward<_Tp>(__t);  // not required to be equality-preserving
+    const_cast<const iter_reference_t<_Out>&&>(*__o) = _VSTD::forward<_Tp>(__t);                       // not required to be equality-preserving
+    const_cast<const iter_reference_t<_Out>&&>(*_VSTD::forward<_Out>(__o)) = _VSTD::forward<_Tp>(__t); // not required to be equality-preserving
+  };
+
 #undef _LIBCPP_NOEXCEPT_RETURN
 #endif // !defined(_LIBCPP_HAS_NO_RANGES)
 
 _LIBCPP_END_NAMESPACE_STD
 
 #endif  // _LIBCPP_ITERATOR

libcxx/test/std/containers/associative/map/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <map>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::map<int, int>::iterator>);
+static_assert(!std::indirectly_writable<std::map<int, int>::iterator, std::map<int, int>::iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::map<int, int>::const_iterator>);
+static_assert(
+    !std::indirectly_writable<std::map<int, int>::const_iterator, std::map<int, int>::const_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::map<int, int>::reverse_iterator>);
+static_assert(
+    !std::indirectly_writable<std::map<int, int>::reverse_iterator, std::map<int, int>::reverse_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::map<int, int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::map<int, int>::const_reverse_iterator,
+                                        std::map<int, int>::const_reverse_iterator::value_type>);

libcxx/test/std/containers/associative/multimap/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <map>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::multimap<int, int>::iterator>);
+static_assert(
+    !std::indirectly_writable<std::multimap<int, int>::iterator, std::multimap<int, int>::iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::multimap<int, int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::multimap<int, int>::const_iterator,
+                                        std::multimap<int, int>::const_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::multimap<int, int>::reverse_iterator>);
+static_assert(!std::indirectly_writable<std::multimap<int, int>::reverse_iterator,
+                                        std::multimap<int, int>::reverse_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::multimap<int, int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::multimap<int, int>::const_reverse_iterator,
+                                        std::multimap<int, int>::const_reverse_iterator::value_type>);

libcxx/test/std/containers/associative/multiset/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <set>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::multiset<int>::iterator>);
+static_assert(!std::indirectly_writable<std::multiset<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::multiset<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::multiset<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::multiset<int>::reverse_iterator>);
+static_assert(!std::indirectly_writable<std::multiset<int>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::multiset<int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::multiset<int>::const_reverse_iterator, int>);

libcxx/test/std/containers/associative/set/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <set>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::set<int>::iterator>);
+static_assert(!std::indirectly_writable<std::set<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::set<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::set<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::set<int>::reverse_iterator>);
+static_assert(!std::indirectly_writable<std::set<int>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::set<int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::set<int>::const_reverse_iterator, int>);

libcxx/test/std/containers/sequences/array/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <array>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::array<int, 10>::iterator>);
+static_assert(std::indirectly_writable<std::array<int, 10>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::array<int, 10>::const_iterator>);
+static_assert(!std::indirectly_writable<std::array<int, 10>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::array<int, 10>::reverse_iterator>);
+static_assert(std::indirectly_writable<std::array<int, 10>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::array<int, 10>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::array<int, 10>::const_reverse_iterator, int>);

libcxx/test/std/containers/sequences/deque/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <deque>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::deque<int>::iterator>);
+static_assert(std::indirectly_writable<std::deque<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::deque<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::deque<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::deque<int>::reverse_iterator>);
+static_assert(std::indirectly_writable<std::deque<int>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::deque<int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::deque<int>::const_reverse_iterator, int>);

libcxx/test/std/containers/sequences/forwardlist/forwardlist.iter/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator
 
 #include <forward_list>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::forward_list<int>::iterator>);
+static_assert(std::indirectly_writable<std::forward_list<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::forward_list<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::forward_list<int>::const_iterator, int>);

libcxx/test/std/containers/sequences/list/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <list>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::list<int>::iterator>);
+static_assert(std::indirectly_writable<std::list<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::list<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::list<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::list<int>::reverse_iterator>);
+static_assert(std::indirectly_writable<std::list<int>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::list<int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::list<int>::const_reverse_iterator, int>);

libcxx/test/std/containers/sequences/vector/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <vector>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::vector<int>::iterator>);
+static_assert(std::indirectly_writable<std::vector<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::vector<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::vector<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::vector<int>::reverse_iterator>);
+static_assert(std::indirectly_writable<std::vector<int>::reverse_iterator, int>);
+
 static_assert(std::indirectly_readable<std::vector<int>::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::vector<int>::const_reverse_iterator, int>);

libcxx/test/std/containers/unord/unord.map/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_map>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::unordered_map<int, int>::iterator>);
+static_assert(!std::indirectly_writable<std::unordered_map<int, int>::iterator,
+                                        std::unordered_map<int, int>::iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_map<int, int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_map<int, int>::const_iterator,
+                                        std::unordered_map<int, int>::const_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_map<int, int>::local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_map<int, int>::local_iterator,
+                                        std::unordered_map<int, int>::local_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_map<int, int>::const_local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_map<int, int>::const_local_iterator,
+                                        std::unordered_map<int, int>::const_local_iterator::value_type>);

libcxx/test/std/containers/unord/unord.multimap/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_map>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::unordered_multimap<int, int>::iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multimap<int, int>::iterator,
+                                        std::unordered_multimap<int, int>::iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_multimap<int, int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multimap<int, int>::const_iterator,
+                                        std::unordered_multimap<int, int>::const_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_multimap<int, int>::local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multimap<int, int>::local_iterator,
+                                        std::unordered_multimap<int, int>::local_iterator::value_type>);
+
 static_assert(std::indirectly_readable<std::unordered_multimap<int, int>::const_local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multimap<int, int>::const_local_iterator,
+                                        std::unordered_multimap<int, int>::const_local_iterator::value_type>);

libcxx/test/std/containers/unord/unord.multiset/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_set>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::unordered_multiset<int>::iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multiset<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_multiset<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multiset<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_multiset<int>::local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multiset<int>::local_iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_multiset<int>::const_local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_multiset<int>::const_local_iterator, int>);

libcxx/test/std/containers/unord/unord.set/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, local_iterator, const_local_iterator
 
 #include <unordered_set>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::unordered_set<int>::iterator>);
+static_assert(!std::indirectly_writable<std::unordered_set<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_set<int>::const_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_set<int>::const_iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_set<int>::local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_set<int>::local_iterator, int>);
+
 static_assert(std::indirectly_readable<std::unordered_set<int>::const_local_iterator>);
+static_assert(!std::indirectly_writable<std::unordered_set<int>::const_local_iterator, int>);

libcxx/test/std/containers/views/span.iterators/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, reverse_iterator
 
 #include <span>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::span<int>::iterator>);
+static_assert(std::indirectly_writable<std::span<int>::iterator, int>);
+
 static_assert(std::indirectly_readable<std::span<int>::reverse_iterator>);
+static_assert(std::indirectly_writable<std::span<int>::reverse_iterator, int>);

libcxx/test/std/input.output/filesystems/class.directory_iterator/iterator_concept_conformance.compile.pass.cpp

 
 // directory_iterator, recursive_directory_iterator
 
 #include "filesystem_include.h"
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<fs::directory_iterator>);
+static_assert(!std::indirectly_writable<fs::directory_iterator, fs::directory_iterator::value_type>);
+
 static_assert(std::indirectly_readable<fs::recursive_directory_iterator>);
+static_assert(
+    !std::indirectly_writable<fs::recursive_directory_iterator, fs::recursive_directory_iterator::value_type>);

libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.writable/indirectly_writable.compile.pass.cpp

+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: libcpp-no-concepts
+// UNSUPPORTED: gcc-10
+
+// template<class In>
+// concept indirectly_writable;
+
+#include <iterator>
+
+#include <concepts>
+#include <memory>
+#include <optional>
+
+#include "read_write.h"
+
+template <class Out, class T>
+[[nodiscard]] constexpr bool check_indirectly_writable() {
+  constexpr bool result = std::indirectly_writable<Out, T>;
+  static_assert(std::indirectly_writable<Out const, T> == result);
+  return result;
+}
+
+static_assert(check_indirectly_writable<value_type_indirection, int>());
+static_assert(check_indirectly_writable<value_type_indirection, double>());
+static_assert(!check_indirectly_writable<value_type_indirection, double*>());
+
+static_assert(!check_indirectly_writable<read_only_indirection, int>());
+static_assert(!check_indirectly_writable<proxy_indirection, int>());
+
+static_assert(!check_indirectly_writable<int, int>());
+static_assert(!check_indirectly_writable<missing_dereference, missing_dereference::value_type>());
+
+namespace standard_types {
+static_assert(!check_indirectly_writable<void*, int>());
+static_assert(!check_indirectly_writable<void const*, int>());
+static_assert(!check_indirectly_writable<void volatile*, int>());
+static_assert(!check_indirectly_writable<void const volatile*, int>());
+static_assert(!check_indirectly_writable<void*, double>());
+static_assert(check_indirectly_writable<void**, int*>());
+static_assert(!check_indirectly_writable<void**, int>());
+
+static_assert(check_indirectly_writable<int*, int>());
+static_assert(!check_indirectly_writable<int const*, int>());
+static_assert(check_indirectly_writable<int volatile*, int>());
+static_assert(!check_indirectly_writable<int const volatile*, int>());
+static_assert(check_indirectly_writable<int*, double>());
+static_assert(check_indirectly_writable<int**, int*>());
+static_assert(!check_indirectly_writable<int**, int>());
+
+// <memory>
+static_assert(check_indirectly_writable<std::shared_ptr<int>, int>());
+static_assert(!check_indirectly_writable<std::shared_ptr<void>, int>());
+static_assert(check_indirectly_writable<std::unique_ptr<int>, int>());
+static_assert(!check_indirectly_writable<std::unique_ptr<void>, int>());
+
+// <optional>
+static_assert(!check_indirectly_writable<std::optional<int>, int>());
+} // namespace standard_types

libcxx/test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/iterator_concept_conformance.compile.pass.cpp

 
 // back_insert_iterator
 
 #include <iterator>
 
 #include <vector>
 
 static_assert(!std::indirectly_readable<std::back_insert_iterator<std::vector<int> > >);
+static_assert(std::indirectly_writable<std::back_insert_iterator<std::vector<int> >, int>);

libcxx/test/std/iterators/predef.iterators/insert.iterators/front.insert.iterator/iterator_concept_conformance.compile.pass.cpp

 
 // front_insert_iterator
 
 #include <iterator>
 
 #include <list>
 
 static_assert(!std::indirectly_readable<std::front_insert_iterator<std::list<int> > >);
+static_assert(std::indirectly_writable<std::front_insert_iterator<std::list<int> >, int>);

libcxx/test/std/iterators/predef.iterators/insert.iterators/insert.iterator/iterator_concept_conformance.compile.pass.cpp

 
 // insert_iterator
 
 #include <iterator>
 
 #include <vector>
 
 static_assert(!std::indirectly_readable<std::insert_iterator<std::vector<int> > >);
+static_assert(std::indirectly_writable<std::insert_iterator<std::vector<int> >, int>);

libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: libcpp-no-concepts
 // UNSUPPORTED: gcc-10
 
 // move_iterator
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::move_iterator<int*> >);
+static_assert(!std::indirectly_writable<std::move_iterator<int*>, int>);

libcxx/test/std/iterators/stream.iterators/istream.iterator/iterator_concept_conformance.compile.pass.cpp

 
 // istream_iterator
 
 #include <iterator>
 
 #include <iosfwd>
 
 static_assert(std::indirectly_readable<std::istream_iterator<int, std::istream> >);
+static_assert(!std::indirectly_writable<std::istream_iterator<int, std::istream>, int>);

libcxx/test/std/iterators/stream.iterators/istreambuf.iterator/iterator_concept_conformance.compile.pass.cpp

 // istreambuf_iterator
 
 #include <iterator>
 
 #include <istream>
 #include <string>
 
 static_assert(std::indirectly_readable<std::istreambuf_iterator<char> >);
+static_assert(!std::indirectly_writable<std::istreambuf_iterator<char>, char>);

libcxx/test/std/iterators/stream.iterators/ostream.iterator/iterator_concept_conformance.compile.pass.cpp

 
 // ostream_iterator
 
 #include <iterator>
 
 #include <iosfwd>
 
 static_assert(!std::indirectly_readable<std::ostream_iterator<int, std::ostream> >);
+static_assert(std::indirectly_writable<std::ostream_iterator<int, std::ostream>, int>);

libcxx/test/std/iterators/stream.iterators/ostreambuf.iterator/iterator_concept_conformance.compile.pass.cpp

 // ostreambuf_iterator
 
 #include <iterator>
 
 #include <ostream>
 #include <string>
 
 static_assert(!std::indirectly_readable<std::ostreambuf_iterator<char> >);
+static_assert(std::indirectly_writable<std::ostreambuf_iterator<char>, char>);

libcxx/test/std/re/re.iter/re.regiter/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: gcc-10
 
 // regex_iterator
 
 #include <regex>
 
 #include <iterator>
 
-static_assert(std::indirectly_readable<std::regex_iterator<std::string_view::iterator> >);
-static_assert(std::indirectly_readable<std::regex_iterator<std::string_view::const_iterator> >);
-static_assert(std::indirectly_readable<std::regex_iterator<std::string_view::reverse_iterator> >);
-static_assert(std::indirectly_readable<std::regex_iterator<std::string_view::const_reverse_iterator> >);
+using iterator = std::regex_iterator<char*>;
+static_assert(std::indirectly_readable<iterator>);
+static_assert(!std::indirectly_writable<iterator, iterator::value_type>);

libcxx/test/std/re/re.iter/re.tokiter/iterator_concept_conformance.compile.pass.cpp

 // UNSUPPORTED: gcc-10
 
 // regex_token_iterator
 
 #include <regex>
 
 #include <iterator>
 
-static_assert(std::indirectly_readable<std::regex_token_iterator<std::string_view::iterator> >);
-static_assert(std::indirectly_readable<std::regex_token_iterator<std::string_view::const_iterator> >);
-static_assert(std::indirectly_readable<std::regex_token_iterator<std::string_view::reverse_iterator> >);
-static_assert(std::indirectly_readable<std::regex_token_iterator<std::string_view::const_reverse_iterator> >);
+using iterator = std::regex_token_iterator<char*>;
+static_assert(std::indirectly_readable<iterator>);
+static_assert(!std::indirectly_writable<iterator, iterator::value_type>);

libcxx/test/std/strings/basic.string/string.iterators/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <string>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::string::iterator>);
+static_assert(std::indirectly_writable<std::string::iterator, char>);
+
 static_assert(std::indirectly_readable<std::string::const_iterator>);
+static_assert(!std::indirectly_writable<std::string::const_iterator, char>);
+
 static_assert(std::indirectly_readable<std::string::reverse_iterator>);
+static_assert(std::indirectly_writable<std::string::reverse_iterator, char>);
+
 static_assert(std::indirectly_readable<std::string::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::string::const_reverse_iterator, char>);

libcxx/test/std/strings/string.view/string.view.iterators/iterator_concept_conformance.compile.pass.cpp

 
 // iterator, const_iterator, reverse_iterator, const_reverse_iterator
 
 #include <string_view>
 
 #include <iterator>
 
 static_assert(std::indirectly_readable<std::string_view::iterator>);
+static_assert(!std::indirectly_writable<std::string_view::iterator, char>);
+
 static_assert(std::indirectly_readable<std::string_view::const_iterator>);
+static_assert(!std::indirectly_writable<std::string_view::const_iterator, char>);
+
 static_assert(std::indirectly_readable<std::string_view::reverse_iterator>);
+static_assert(!std::indirectly_writable<std::string_view::reverse_iterator, char>);
+
 static_assert(std::indirectly_readable<std::string_view::const_reverse_iterator>);
+static_assert(!std::indirectly_writable<std::string_view::const_reverse_iterator, char>);